From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Nelson Date: Sat, 28 Apr 2012 08:36:40 -0700 Subject: [U-Boot] [PATCH V3] i.MX6: mx6q_sabrelite: add SATA bindings In-Reply-To: <4F9C03F5.8030308@googlemail.com> References: <1335397801-25967-1-git-send-email-eric.nelson@boundarydevices.com> <4F9C03F5.8030308@googlemail.com> Message-ID: <4F9C0E88.5060404@boundarydevices.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Dirk, On 04/28/2012 07:51 AM, Dirk Behme wrote: > Hi Eric, > > On 26.04.2012 01:50, Eric Nelson wrote: >> Signed-off-by: Eric Nelson >> >> --- >> V2 has been stripped of the board-independent changes and >> uses clrsetbits_le32() instead of twiddling bits by hand. >> >> V3 returns immediately from setup_sata() if enable_sata_clock() >> returns an error. >> >> board/freescale/mx6qsabrelite/mx6qsabrelite.c | 32 +++++++++++++++++++++++++ >> include/configs/mx6qsabrelite.h | 13 ++++++++++ >> 2 files changed, 45 insertions(+), 0 deletions(-) >> >> diff --git a/board/freescale/mx6qsabrelite/mx6qsabrelite.c >> b/board/freescale/mx6qsabrelite/mx6qsabrelite.c >> index 1d09a72..c9a108f 100644 >> --- a/board/freescale/mx6qsabrelite/mx6qsabrelite.c >> +++ b/board/freescale/mx6qsabrelite/mx6qsabrelite.c >> @@ -25,6 +25,8 @@ >> #include >> #include >> #include >> +#include > > Do we need ccm_regs.h here? > Nope. Good catch. I'll generate a V4 in a day or two to allow some other review. Stefano, what's the status of the dwc_ahsata driver? Without that, the bindings are clearly useless. Regards, Eric