From: Donghwa Lee <dh09.lee@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 2/3] LCD: add compressed 32bpp BMP image data
Date: Mon, 30 Apr 2012 15:06:21 +0900 [thread overview]
Message-ID: <4F9E2BDD.3030904@samsung.com> (raw)
In-Reply-To: <CALrBrZ1jfNM-Ry3qv=22=o2HuGbx6JLhuHA8pKM7fdC3iNmAJg@mail.gmail.com>
Dear Wolfgang Denk,
Mr.Kang and I think TIZEN logo is not a board/vendor specific although samsung
will release it. So, Mr.kang had proposed new directory include/video or
include/video/logo/.
How do you think about that? When you receive this e-mail, please replay with
your opinions.
Thank you,
Donghwa Lee
On 27 April 2012 09:18, Minkyu Kang wrote:
> Dear Wolfgang Denk,
>
> On 26 April 2012 21:43, Wolfgang Denk <wd@denx.de> wrote:
>> Dear Donghwa Lee,
>>
>> In message <4F99057F.5040907@samsung.com> you wrote:
>>> This patch is 32bpp BMP image data that is converted to header
>>> after gzip. I had agonized about where these data located.
>>> I think TIZEN is not specific on board and SoC, so I determined
>>> that position is proper in include/.
>>> If you have other opinions, please comment to me.
>>>
>>> Signed-off-by: Donghwa Lee <dh09.lee@samsung.com>
>>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>>> ---
>>> include/tizen_logo.h | 5071 +++++++++++++++++++++++++++++++++++++++++++++
>>> include/tizen_logo_data.h | 30 +
>>> 2 files changed, 5101 insertions(+), 0 deletions(-)
>>> create mode 100644 include/tizen_logo.h
>>> create mode 100644 include/tizen_logo_data.h
>>
>> Please make sure to include a changelog; this is a mandatory
>> requirement, see
>> http://www.denx.de/wiki/view/U-Boot/Patches#Sending_updated_patch_versions
>>
>>
>> I reject your patch. I will not accept to have such board and/or
>> vendor specific data in the top level include/ directory. Please move
>> this to the respective board or vendor directory, as I have asked you
>> do to before.
>>
>
> But I think TIZEN logo is not a board/vendor specific.
> It's a platform specific.
> How do you think that makes a new directory?
> (e.g: include/video/ or include/video/logo/)
>
> Thnaks.
> Minkyu Kang.
next prev parent reply other threads:[~2012-04-30 6:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-26 8:21 [U-Boot] [PATCH v2 2/3] LCD: add compressed 32bpp BMP image data Donghwa Lee
2012-04-26 12:43 ` Wolfgang Denk
2012-04-27 0:18 ` Minkyu Kang
2012-04-30 6:06 ` Donghwa Lee [this message]
2012-04-30 9:02 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F9E2BDD.3030904@samsung.com \
--to=dh09.lee@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox