From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Nelson <eric.nelson@boundarydevices.com>
Date: Mon, 30 Apr 2012 06:33:01 -0700
Subject: [U-Boot] [PATCH V3] i.MX6: mx6q_sabrelite: add SATA bindings
In-Reply-To: <201204300427.59892.marex@denx.de>
References: <http://lists.denx.de/pipermail/u-boot/2012-March/120150.html>
	<1335397801-25967-1-git-send-email-eric.nelson@boundarydevices.com>
	<201204300427.59892.marex@denx.de>
Message-ID: <4F9E948D.4070705@boundarydevices.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Marek,

On 04/29/2012 07:27 PM, Marek Vasut wrote:
> Dear Eric Nelson,
>
>> Signed-off-by: Eric Nelson<eric.nelson@boundarydevices.com>
>>
>> ---
>> V2 has been stripped of the board-independent changes and
>> uses clrsetbits_le32() instead of twiddling bits by hand.
>>
 >> <snip>
 >>
>> +int setup_sata(void)
>> +{
>> +	struct iomuxc_base_regs *const iomuxc_regs
>> +		= (struct iomuxc_base_regs *) IOMUXC_BASE_ADDR;
>> +	int rval = enable_sata_clock();
>> +	if (rval)
>> +		return rval ;
>
> Can you keep the return<val>; consistent with the rest of the file? (so avoid
> return<val>[space];) ... I dunno if this violates some coding style document
> though. Just a nitpick.
>

Can do. I'll update this in V4.