From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Nelson Date: Tue, 01 May 2012 12:53:42 -0700 Subject: [U-Boot] [PATCH V4] i.MX6: mx6q_sabrelite: add SATA bindings In-Reply-To: <201205012125.59644.marex@denx.de> References: <1335900246-10072-1-git-send-email-eric.nelson@boundarydevices.com> <201205012125.59644.marex@denx.de> Message-ID: <4FA03F46.5010203@boundarydevices.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 05/01/2012 12:25 PM, Marek Vasut wrote: > Dear Eric Nelson, > >> Signed-off-by: Eric Nelson >> --- >> V2 has been stripped of the board-independent changes and >> uses clrsetbits_le32() instead of twiddling bits by hand. >> >> V3 returns immediately from setup_sata() if enable_sata_clock() >> returns an error. >> >> V4 removes extra #include and addresses a style issue as discussed >> on the ML. > > It's still there ;-) >> >> >> >> + |IOMUXC_GPR13_SATA_PHY_2_TX_1P104V >> + |IOMUXC_GPR13_SATA_PHY_1_SLOW); >> + > >> + return 0 ;<---- here :-) > My eyes are clearly not as finely tuned as yours... What are the odd that I could tweak checkpatch.pl without introducing another style issue? V5 forthcoming...