From: Wolfgang Grandegger <wg@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] USB: ehci-mx6: Fix broken IO access
Date: Wed, 02 May 2012 21:30:40 +0200 [thread overview]
Message-ID: <4FA18B60.3070309@denx.de> (raw)
In-Reply-To: <CAOMZO5B0uk8yUY-TujFShgFUwV3PUH-4e=FJr27v4a6DSz8z_A@mail.gmail.com>
Hi Fabio,
On 05/02/2012 05:24 PM, Fabio Estevam wrote:
> On Wed, May 2, 2012 at 11:36 AM, Wolfgang Grandegger <wg@denx.de> wrote:
>> To get USB working again on the i.MX6, this patch fixes a bug introduced
>> with commit 522b2a0 "Add proper IO accessors for mx6 usb registers.".
>
> Good catch on the usb register name change.
>
>> At that occasion, I also added the missing __iomem directive.
>
> Is this really needed?
As I see it, __iomem is a dummy function in U-Boot. I just added it for
consistency reasons. If we remove it, we should also remove all other
__iomem's from that file. Maybe somebody else could clarify if __iomem
should be used.
Wolfgang.
next prev parent reply other threads:[~2012-05-02 19:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-02 14:36 [U-Boot] [PATCH] USB: ehci-mx6: Fix broken IO access Wolfgang Grandegger
2012-05-02 15:24 ` Fabio Estevam
2012-05-02 19:30 ` Wolfgang Grandegger [this message]
2012-05-06 16:35 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA18B60.3070309@denx.de \
--to=wg@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox