From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Grandegger Date: Wed, 02 May 2012 21:30:40 +0200 Subject: [U-Boot] [PATCH] USB: ehci-mx6: Fix broken IO access In-Reply-To: References: <4FA14677.30206@denx.de> Message-ID: <4FA18B60.3070309@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Fabio, On 05/02/2012 05:24 PM, Fabio Estevam wrote: > On Wed, May 2, 2012 at 11:36 AM, Wolfgang Grandegger wrote: >> To get USB working again on the i.MX6, this patch fixes a bug introduced >> with commit 522b2a0 "Add proper IO accessors for mx6 usb registers.". > > Good catch on the usb register name change. > >> At that occasion, I also added the missing __iomem directive. > > Is this really needed? As I see it, __iomem is a dummy function in U-Boot. I just added it for consistency reasons. If we remove it, we should also remove all other __iomem's from that file. Maybe somebody else could clarify if __iomem should be used. Wolfgang.