* [U-Boot] [PATCH] mx28evk: add NAND support
@ 2012-04-17 10:35 Lauri Hintsala
2012-04-17 11:21 ` Marek Vasut
2012-05-06 16:42 ` Stefano Babic
0 siblings, 2 replies; 10+ messages in thread
From: Lauri Hintsala @ 2012-04-17 10:35 UTC (permalink / raw)
To: u-boot
NAND support is not enabled by default because Eval Kit is not delivered
with NAND chip. To enable NAND support add CONFIG_CMD_NAND to board config.
Signed-off-by: Lauri Hintsala <lauri.hintsala@bluegiga.com>
---
board/freescale/mx28evk/iomux.c | 21 +++++++++++++++++++++
include/configs/mx28evk.h | 10 ++++++++++
2 files changed, 31 insertions(+), 0 deletions(-)
diff --git a/board/freescale/mx28evk/iomux.c b/board/freescale/mx28evk/iomux.c
index 396761b..6587c45 100644
--- a/board/freescale/mx28evk/iomux.c
+++ b/board/freescale/mx28evk/iomux.c
@@ -26,6 +26,7 @@
#include <asm/arch/sys_proto.h>
#define MUX_CONFIG_SSP0 (MXS_PAD_3V3 | MXS_PAD_8MA | MXS_PAD_PULLUP)
+#define MUX_CONFIG_GPMI (MXS_PAD_3V3 | MXS_PAD_4MA | MXS_PAD_NOPULL)
#define MUX_CONFIG_ENET (MXS_PAD_3V3 | MXS_PAD_8MA | MXS_PAD_PULLUP)
#define MUX_CONFIG_EMI (MXS_PAD_3V3 | MXS_PAD_12MA | MXS_PAD_NOPULL)
#define MUX_CONFIG_SSP2 (MXS_PAD_3V3 | MXS_PAD_4MA | MXS_PAD_PULLUP)
@@ -55,6 +56,26 @@ const iomux_cfg_t iomux_setup[] = {
MX28_PAD_PWM3__GPIO_3_28 |
(MXS_PAD_12MA | MXS_PAD_3V3 | MXS_PAD_PULLUP),
+#ifdef CONFIG_NAND_MXS
+ /* GPMI NAND */
+ MX28_PAD_GPMI_D00__GPMI_D0 | MUX_CONFIG_GPMI,
+ MX28_PAD_GPMI_D01__GPMI_D1 | MUX_CONFIG_GPMI,
+ MX28_PAD_GPMI_D02__GPMI_D2 | MUX_CONFIG_GPMI,
+ MX28_PAD_GPMI_D03__GPMI_D3 | MUX_CONFIG_GPMI,
+ MX28_PAD_GPMI_D04__GPMI_D4 | MUX_CONFIG_GPMI,
+ MX28_PAD_GPMI_D05__GPMI_D5 | MUX_CONFIG_GPMI,
+ MX28_PAD_GPMI_D06__GPMI_D6 | MUX_CONFIG_GPMI,
+ MX28_PAD_GPMI_D07__GPMI_D7 | MUX_CONFIG_GPMI,
+ MX28_PAD_GPMI_CE0N__GPMI_CE0N | MUX_CONFIG_GPMI,
+ MX28_PAD_GPMI_RDY0__GPMI_READY0 | MUX_CONFIG_GPMI,
+ MX28_PAD_GPMI_RDN__GPMI_RDN |
+ (MXS_PAD_3V3 | MXS_PAD_8MA | MXS_PAD_PULLUP),
+ MX28_PAD_GPMI_WRN__GPMI_WRN | MUX_CONFIG_GPMI,
+ MX28_PAD_GPMI_ALE__GPMI_ALE | MUX_CONFIG_GPMI,
+ MX28_PAD_GPMI_CLE__GPMI_CLE | MUX_CONFIG_GPMI,
+ MX28_PAD_GPMI_RESETN__GPMI_RESETN | MUX_CONFIG_GPMI,
+#endif
+
/* FEC0 */
MX28_PAD_ENET0_MDC__ENET0_MDC | MUX_CONFIG_ENET,
MX28_PAD_ENET0_MDIO__ENET0_MDIO | MUX_CONFIG_ENET,
diff --git a/include/configs/mx28evk.h b/include/configs/mx28evk.h
index 02f3366..2a44baa 100644
--- a/include/configs/mx28evk.h
+++ b/include/configs/mx28evk.h
@@ -148,6 +148,16 @@
#endif
/*
+ * NAND Driver
+ */
+#ifdef CONFIG_CMD_NAND
+#define CONFIG_NAND_MXS
+#define CONFIG_SYS_MAX_NAND_DEVICE 1
+#define CONFIG_SYS_NAND_BASE 0x60000000
+#define CONFIG_SYS_NAND_5_ADDR_CYCLE
+#endif
+
+/*
* Ethernet on SOC (FEC)
*/
#ifdef CONFIG_CMD_NET
--
1.7.5.4
^ permalink raw reply related [flat|nested] 10+ messages in thread* [U-Boot] [PATCH] mx28evk: add NAND support
2012-04-17 10:35 [U-Boot] [PATCH] mx28evk: add NAND support Lauri Hintsala
@ 2012-04-17 11:21 ` Marek Vasut
2012-04-17 13:34 ` Fabio Estevam
2012-04-17 14:30 ` Stefano Babic
2012-05-06 16:42 ` Stefano Babic
1 sibling, 2 replies; 10+ messages in thread
From: Marek Vasut @ 2012-04-17 11:21 UTC (permalink / raw)
To: u-boot
Dear Lauri Hintsala,
> NAND support is not enabled by default because Eval Kit is not delivered
> with NAND chip. To enable NAND support add CONFIG_CMD_NAND to board config.
>
> Signed-off-by: Lauri Hintsala <lauri.hintsala@bluegiga.com>
Acked-by: Marek Vasut <marex@denx.de>
I think we can schedule it for .04 release as this is basically a fix? Fabio ?
> ---
> board/freescale/mx28evk/iomux.c | 21 +++++++++++++++++++++
> include/configs/mx28evk.h | 10 ++++++++++
> 2 files changed, 31 insertions(+), 0 deletions(-)
>
> diff --git a/board/freescale/mx28evk/iomux.c
> b/board/freescale/mx28evk/iomux.c index 396761b..6587c45 100644
> --- a/board/freescale/mx28evk/iomux.c
> +++ b/board/freescale/mx28evk/iomux.c
> @@ -26,6 +26,7 @@
> #include <asm/arch/sys_proto.h>
>
> #define MUX_CONFIG_SSP0 (MXS_PAD_3V3 | MXS_PAD_8MA | MXS_PAD_PULLUP)
> +#define MUX_CONFIG_GPMI (MXS_PAD_3V3 | MXS_PAD_4MA | MXS_PAD_NOPULL)
> #define MUX_CONFIG_ENET (MXS_PAD_3V3 | MXS_PAD_8MA | MXS_PAD_PULLUP)
> #define MUX_CONFIG_EMI (MXS_PAD_3V3 | MXS_PAD_12MA | MXS_PAD_NOPULL)
> #define MUX_CONFIG_SSP2 (MXS_PAD_3V3 | MXS_PAD_4MA | MXS_PAD_PULLUP)
> @@ -55,6 +56,26 @@ const iomux_cfg_t iomux_setup[] = {
> MX28_PAD_PWM3__GPIO_3_28 |
> (MXS_PAD_12MA | MXS_PAD_3V3 | MXS_PAD_PULLUP),
>
> +#ifdef CONFIG_NAND_MXS
> + /* GPMI NAND */
> + MX28_PAD_GPMI_D00__GPMI_D0 | MUX_CONFIG_GPMI,
> + MX28_PAD_GPMI_D01__GPMI_D1 | MUX_CONFIG_GPMI,
> + MX28_PAD_GPMI_D02__GPMI_D2 | MUX_CONFIG_GPMI,
> + MX28_PAD_GPMI_D03__GPMI_D3 | MUX_CONFIG_GPMI,
> + MX28_PAD_GPMI_D04__GPMI_D4 | MUX_CONFIG_GPMI,
> + MX28_PAD_GPMI_D05__GPMI_D5 | MUX_CONFIG_GPMI,
> + MX28_PAD_GPMI_D06__GPMI_D6 | MUX_CONFIG_GPMI,
> + MX28_PAD_GPMI_D07__GPMI_D7 | MUX_CONFIG_GPMI,
> + MX28_PAD_GPMI_CE0N__GPMI_CE0N | MUX_CONFIG_GPMI,
> + MX28_PAD_GPMI_RDY0__GPMI_READY0 | MUX_CONFIG_GPMI,
> + MX28_PAD_GPMI_RDN__GPMI_RDN |
> + (MXS_PAD_3V3 | MXS_PAD_8MA | MXS_PAD_PULLUP),
> + MX28_PAD_GPMI_WRN__GPMI_WRN | MUX_CONFIG_GPMI,
> + MX28_PAD_GPMI_ALE__GPMI_ALE | MUX_CONFIG_GPMI,
> + MX28_PAD_GPMI_CLE__GPMI_CLE | MUX_CONFIG_GPMI,
> + MX28_PAD_GPMI_RESETN__GPMI_RESETN | MUX_CONFIG_GPMI,
> +#endif
> +
> /* FEC0 */
> MX28_PAD_ENET0_MDC__ENET0_MDC | MUX_CONFIG_ENET,
> MX28_PAD_ENET0_MDIO__ENET0_MDIO | MUX_CONFIG_ENET,
> diff --git a/include/configs/mx28evk.h b/include/configs/mx28evk.h
> index 02f3366..2a44baa 100644
> --- a/include/configs/mx28evk.h
> +++ b/include/configs/mx28evk.h
> @@ -148,6 +148,16 @@
> #endif
>
> /*
> + * NAND Driver
> + */
> +#ifdef CONFIG_CMD_NAND
> +#define CONFIG_NAND_MXS
> +#define CONFIG_SYS_MAX_NAND_DEVICE 1
> +#define CONFIG_SYS_NAND_BASE 0x60000000
> +#define CONFIG_SYS_NAND_5_ADDR_CYCLE
> +#endif
> +
> +/*
> * Ethernet on SOC (FEC)
> */
> #ifdef CONFIG_CMD_NET
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 10+ messages in thread* [U-Boot] [PATCH] mx28evk: add NAND support
2012-04-17 11:21 ` Marek Vasut
@ 2012-04-17 13:34 ` Fabio Estevam
2012-04-17 14:22 ` Marek Vasut
2012-04-17 14:30 ` Stefano Babic
1 sibling, 1 reply; 10+ messages in thread
From: Fabio Estevam @ 2012-04-17 13:34 UTC (permalink / raw)
To: u-boot
On 4/17/12, Marek Vasut <marex@denx.de> wrote:
> Dear Lauri Hintsala,
>
>> NAND support is not enabled by default because Eval Kit is not delivered
>> with NAND chip. To enable NAND support add CONFIG_CMD_NAND to board
>> config.
>>
>> Signed-off-by: Lauri Hintsala <lauri.hintsala@bluegiga.com>
>
> Acked-by: Marek Vasut <marex@denx.de>
>
> I think we can schedule it for .04 release as this is basically a fix? Fabio
> ?
Looks good to me. My only suggestion (can be part of a separate patch)
is to modify the mx28evk README and explain that mx28evk can also boot
from NAND and explain the boot mode settings, etc.
Thanks,
Fabio Estevam
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH] mx28evk: add NAND support
2012-04-17 13:34 ` Fabio Estevam
@ 2012-04-17 14:22 ` Marek Vasut
0 siblings, 0 replies; 10+ messages in thread
From: Marek Vasut @ 2012-04-17 14:22 UTC (permalink / raw)
To: u-boot
Dear Fabio Estevam,
> On 4/17/12, Marek Vasut <marex@denx.de> wrote:
> > Dear Lauri Hintsala,
> >
> >> NAND support is not enabled by default because Eval Kit is not delivered
> >> with NAND chip. To enable NAND support add CONFIG_CMD_NAND to board
> >> config.
> >>
> >> Signed-off-by: Lauri Hintsala <lauri.hintsala@bluegiga.com>
> >
> > Acked-by: Marek Vasut <marex@denx.de>
> >
> > I think we can schedule it for .04 release as this is basically a fix?
> > Fabio ?
>
> Looks good to me. My only suggestion (can be part of a separate patch)
> is to modify the mx28evk README and explain that mx28evk can also boot
> from NAND and explain the boot mode settings, etc.
Good idea, but let's do this in a separate patch :)
>
> Thanks,
>
> Fabio Estevam
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH] mx28evk: add NAND support
2012-04-17 11:21 ` Marek Vasut
2012-04-17 13:34 ` Fabio Estevam
@ 2012-04-17 14:30 ` Stefano Babic
2012-04-17 14:46 ` Marek Vasut
2012-05-02 17:26 ` Fabio Estevam
1 sibling, 2 replies; 10+ messages in thread
From: Stefano Babic @ 2012-04-17 14:30 UTC (permalink / raw)
To: u-boot
On 17/04/2012 13:21, Marek Vasut wrote:
> Dear Lauri Hintsala,
>
>> NAND support is not enabled by default because Eval Kit is not delivered
>> with NAND chip. To enable NAND support add CONFIG_CMD_NAND to board config.
>>
>> Signed-off-by: Lauri Hintsala <lauri.hintsala@bluegiga.com>
>
> Acked-by: Marek Vasut <marex@denx.de>
>
> I think we can schedule it for .04 release as this is basically a fix? Fabio ?
Well, this is not a fix because it adds a feature that is not yet
supported. It should be deferred to the next release.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH] mx28evk: add NAND support
2012-04-17 14:30 ` Stefano Babic
@ 2012-04-17 14:46 ` Marek Vasut
2012-05-02 17:26 ` Fabio Estevam
1 sibling, 0 replies; 10+ messages in thread
From: Marek Vasut @ 2012-04-17 14:46 UTC (permalink / raw)
To: u-boot
Dear Stefano Babic,
> On 17/04/2012 13:21, Marek Vasut wrote:
> > Dear Lauri Hintsala,
> >
> >> NAND support is not enabled by default because Eval Kit is not delivered
> >> with NAND chip. To enable NAND support add CONFIG_CMD_NAND to board
> >> config.
> >>
> >> Signed-off-by: Lauri Hintsala <lauri.hintsala@bluegiga.com>
> >
> > Acked-by: Marek Vasut <marex@denx.de>
> >
> > I think we can schedule it for .04 release as this is basically a fix?
> > Fabio ?
>
> Well, this is not a fix because it adds a feature that is not yet
> supported. It should be deferred to the next release.
Ok, I won't object either way as it doesn't concern me that much ;-)
>
> Best regards,
> Stefano Babic
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH] mx28evk: add NAND support
2012-04-17 14:30 ` Stefano Babic
2012-04-17 14:46 ` Marek Vasut
@ 2012-05-02 17:26 ` Fabio Estevam
2012-05-02 17:53 ` Marek Vasut
2012-05-02 20:58 ` stefano babic
1 sibling, 2 replies; 10+ messages in thread
From: Fabio Estevam @ 2012-05-02 17:26 UTC (permalink / raw)
To: u-boot
Hi Stefano,
On Tue, Apr 17, 2012 at 11:30 AM, Stefano Babic <sbabic@denx.de> wrote:
> Well, this is not a fix because it adds a feature that is not yet
> supported. It should be deferred to the next release.
Can this be applied now?
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH] mx28evk: add NAND support
2012-05-02 17:26 ` Fabio Estevam
@ 2012-05-02 17:53 ` Marek Vasut
2012-05-02 20:58 ` stefano babic
1 sibling, 0 replies; 10+ messages in thread
From: Marek Vasut @ 2012-05-02 17:53 UTC (permalink / raw)
To: u-boot
Dear Fabio Estevam,
> Hi Stefano,
>
> On Tue, Apr 17, 2012 at 11:30 AM, Stefano Babic <sbabic@denx.de> wrote:
> > Well, this is not a fix because it adds a feature that is not yet
> > supported. It should be deferred to the next release.
>
> Can this be applied now?
Should be ...
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH] mx28evk: add NAND support
2012-05-02 17:26 ` Fabio Estevam
2012-05-02 17:53 ` Marek Vasut
@ 2012-05-02 20:58 ` stefano babic
1 sibling, 0 replies; 10+ messages in thread
From: stefano babic @ 2012-05-02 20:58 UTC (permalink / raw)
To: u-boot
Am 02/05/2012 19:26, schrieb Fabio Estevam:
> Hi Stefano,
>
> On Tue, Apr 17, 2012 at 11:30 AM, Stefano Babic <sbabic@denx.de> wrote:
>
>> Well, this is not a fix because it adds a feature that is not yet
>> supported. It should be deferred to the next release.
>
> Can this be applied now?
>
Yes, I will do it.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH] mx28evk: add NAND support
2012-04-17 10:35 [U-Boot] [PATCH] mx28evk: add NAND support Lauri Hintsala
2012-04-17 11:21 ` Marek Vasut
@ 2012-05-06 16:42 ` Stefano Babic
1 sibling, 0 replies; 10+ messages in thread
From: Stefano Babic @ 2012-05-06 16:42 UTC (permalink / raw)
To: u-boot
On 17/04/2012 12:35, Lauri Hintsala wrote:
> NAND support is not enabled by default because Eval Kit is not delivered
> with NAND chip. To enable NAND support add CONFIG_CMD_NAND to board config.
>
> Signed-off-by: Lauri Hintsala <lauri.hintsala@bluegiga.com>
> ---
Applied to u-boot-imx, thanks
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2012-05-06 16:42 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-17 10:35 [U-Boot] [PATCH] mx28evk: add NAND support Lauri Hintsala
2012-04-17 11:21 ` Marek Vasut
2012-04-17 13:34 ` Fabio Estevam
2012-04-17 14:22 ` Marek Vasut
2012-04-17 14:30 ` Stefano Babic
2012-04-17 14:46 ` Marek Vasut
2012-05-02 17:26 ` Fabio Estevam
2012-05-02 17:53 ` Marek Vasut
2012-05-02 20:58 ` stefano babic
2012-05-06 16:42 ` Stefano Babic
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox