From: Aaron Williams <Aaron.Williams@cavium.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/1] fat: FAT sector offsets overflow on large disks and/or FAT partitions
Date: Wed, 02 May 2012 19:17:41 -0700 [thread overview]
Message-ID: <4FA1EAC5.8000003@cavium.com> (raw)
This patch fixes several issues where sector offsets can overflow due to
being limited to 16-bits. There are many cases which can cause an
overflow, including large FAT32 partitions and partitions that start at
a sufficiently large offset on the storage device.
Numerous issues were observed and fixed when a 64GB FAT32 filesystem was
accessed due to truncation.
Signed-off-by: Aaron Williams <aaron.williams@caviumnetworks.com>
---
include/fat.h | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/include/fat.h b/include/fat.h
index 4c92442..7215628 100644
--- a/include/fat.h
+++ b/include/fat.h
@@ -178,12 +178,12 @@ typedef struct dir_slot {
typedef struct {
__u8 *fatbuf; /* Current FAT buffer */
int fatsize; /* Size of FAT in bits */
- __u16 fatlength; /* Length of FAT in sectors */
- __u16 fat_sect; /* Starting sector of the FAT */
- __u16 rootdir_sect; /* Start sector of root directory */
- __u16 sect_size; /* Size of sectors in bytes */
+ __u32 fat_sect; /* Starting sector of the FAT */
+ __u32 rootdir_sect; /* Start sector of root directory */
+ __u32 fatlength; /* Length of FAT in sectors */
__u16 clust_size; /* Size of clusters in sectors */
- short data_begin; /* The sector of the first cluster, can be negative */
+ __u16 sect_size; /* Size of sectors in bytes */
+ int data_begin; /* The sector of the first cluster, can be negative */
int fatbufnum; /* Used by get_fatent, init to -1 */
} fsdata;
--
1.7.7
next reply other threads:[~2012-05-03 2:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-03 2:17 Aaron Williams [this message]
2012-05-08 2:10 ` [U-Boot] [PATCH 1/1] fat: FAT sector offsets overflow on large disks and/or FAT partitions Aaron Williams
2012-05-12 15:41 ` Anatolij Gustschin
2012-05-14 22:54 ` Aaron Williams
2012-05-19 17:20 ` [U-Boot] [PATCH] fat: fix FAT sector offsets overflow on large " Anatolij Gustschin
2012-05-22 8:14 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA1EAC5.8000003@cavium.com \
--to=aaron.williams@cavium.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox