[U-Boot] [PATCH 5/8] MXC FEC: Resolve speed before configuring gasket

Timo Ketola
2012-04-12T13:16:26Z

On 12.04.2012 15:05, Stefano Babic wrote:
> On 12/04/2012 11:33, Timo Ketola wrote:
>> Signed-off-by: Timo Ketola<timo@exertus.fi>

>> --- a/drivers/net/fec_mxc.c
>> +++ b/drivers/net/fec_mxc.c
>
> Please consider to rebase your patch on u-boot-imx, next branch. There
> are already a couple of patches related to gasket and MII.

u-boot-imx is separate repository, right? So I have to clone that and apply my
patches manually, right?

>> + // FIXME: useless call: miiphy_duplex(edev->name, fec->phy_id);
>
> This is dead code. // comments are not allowed, comment should be real
> comments, not used to disable code. Why are you disabling ? Please
> explain the reason and, if it is required, provide a separate patch for
> this.

Return value is discarded and I didn't find any side effects. So it seems to be
dead call. If agreed, then I'll edit the patch.

--

Timo