[U-Boot] [PATCH 7/9] imx: esdhc: Needed to use in imx-regs.h defined address

Timo Ketola
2012-04-18T09:11:05Z

On 18.04.2012 11:43, Stefano Babic wrote:
> On 18/04/2012 09:57, Timo Ketola wrote:
>> One might want to define CONFIG_SYS_FSL_ESDHC_ADDR with the macro already
>> define in imx-regs.h, e.g. with IMX_MMC_SDHC1_BASE. Then the header must be
>> included here.
>> ...
>> diff --git a/drivers/mmc/fsl_esdhc.c b/drivers/mmc/fsl_esdhc.c
>> ...
>> +#include<asm/arch/imx-regs.h>
>
> NAK. There is a good reason to avoid it. The fsl_esdhc driver is common
> to both i.MX and PowerPc architecture, and of course PowerPC have not
> imx-regs.h. And CONFIG_SYS_FSL_ESDHC_ADDR cannot be set by a macro in
> imx-regs.h, because it is different on PowerPC.

Ok, I was afraid about something like that and tried first to include it in
board configuration but that broke something else (at least arm926ejs didn't
compile any more).

> By the way, why do you need it if you do not use that macro ?

I use it in my board (support of which I'm preparing to send) configuration
file and I think it is annoying to write a literal constant there which is
already defined in imx-regs.h.

PPC seems to use a predefined macro from asm/immap_8xxx.h files. Where is that
file included?

--

Timo