From: Eric Nelson <eric.nelson@boundarydevices.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH, V2] Resend: i.MX6: add enable_sata_clock()
Date: Sun, 06 May 2012 10:42:33 -0700 [thread overview]
Message-ID: <4FA6B809.1090206@boundarydevices.com> (raw)
In-Reply-To: <4FA6AF1B.2020307@denx.de>
Hi Stefano,
On 05/06/2012 10:04 AM, Stefano Babic wrote:
> On 28/04/2012 17:29, Eric Nelson wrote:
>
>> Hi Dirk,
>>
>> I tried to address this global/non-const by making it explicitly public,
>> but Stefano nacked the patch:
>> http://patchwork.ozlabs.org/patch/144712/
>>
>> As it stands, the compiler won't generate an external reference for the
>> local above, so it should be good.
>
> It seems ok. However, this conflicts with
>
> imx-common: Factor out get_ahb_clk()
>
> sent by Fabio Estevam.
>
> Reason is only the modified structure name : I made these changes to
> your patch:
>
> diff --git a/arch/arm/cpu/armv7/mx6/clock.c b/arch/arm/cpu/armv7/mx6/clock.c
> index 3255771..52d5dc4 100644
> --- a/arch/arm/cpu/armv7/mx6/clock.c
> +++ b/arch/arm/cpu/armv7/mx6/clock.c
> @@ -296,8 +296,8 @@ int enable_sata_clock(void)
> {
> u32 reg = 0;
> s32 timeout = 100000;
> - struct imx_ccm_reg *const imx_ccm
> - = (struct imx_ccm_reg *) CCM_BASE_ADDR;
> + struct mxc_ccm_reg *const imx_ccm
> + = (struct mxc_ccm_reg *) CCM_BASE_ADDR;
>
> /* Enable sata clock */
>
> Change is trivial, but please take a look.
>
This is clearly fine, but it has me laughing because I never
remember what 'mxc' stands for.
Regards,
Eric
next prev parent reply other threads:[~2012-05-06 17:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <http://lists.denx.de/pipermail/u-boot/2012-March/121135.html>
2012-04-25 23:48 ` [U-Boot] [PATCH, V2] Resend: i.MX6: add enable_sata_clock() Eric Nelson
2012-04-28 14:42 ` Dirk Behme
2012-04-28 15:29 ` Eric Nelson
2012-05-06 17:04 ` Stefano Babic
2012-05-06 17:42 ` Eric Nelson [this message]
2012-05-06 18:08 ` Fabio Estevam
2012-05-06 18:33 ` Eric Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA6B809.1090206@boundarydevices.com \
--to=eric.nelson@boundarydevices.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox