public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jaehoon Chung <jh80.chung@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-BOOT][PATCH] mmc: remove the hard setting for tran_speed
Date: Tue, 08 May 2012 11:51:35 +0900	[thread overview]
Message-ID: <4FA88A37.4040103@samsung.com> (raw)
In-Reply-To: <CAKWjMd7=6Azwyc4TTcrY=4m39LX26NkkOvbVAvjPGxmOWyUDug@mail.gmail.com>

Hi Andy.

On 05/08/2012 06:50 AM, Andy Fleming wrote:

> On Mon, Apr 2, 2012 at 1:31 PM, Jae hoon Chung <jh80.chung@gmail.com> wrote:
> 
>>>                if (mmc->card_caps & MMC_MODE_HS) {
>>>                        if (mmc->card_caps & MMC_MODE_HS_52MHz)
>>> -                               mmc_set_clock(mmc, 52000000);
>>> +                               mmc->tran_speed = 52000000;
>>>                        else
>>> -                               mmc_set_clock(mmc, 26000000);
>>> -               } else
>>> -                       mmc_set_clock(mmc, 20000000);
>>> +                               mmc->tran_speed = 26000000;
>>> +               }
> 
> 
> Why did you remove the outer else clause, here (the one that set the
> speed to 20000000)?
> 

If card->caps didn't set MMC_MODE_HS, then it's set to mmc->tran_speed.
That value is assigned from freq * mult.

I think that is reasonable..if set to 20000000 here, then why need freq & mult?

Best Regards,
Jaehoon Chung

  reply	other threads:[~2012-05-08  2:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-27  7:16 [U-Boot] [U-BOOT][PATCH] mmc: remove the hard setting for tran_speed Jaehoon Chung
2012-04-02 18:31 ` Jae hoon Chung
2012-05-07 21:50   ` Andy Fleming
2012-05-08  2:51     ` Jaehoon Chung [this message]
2012-05-08 21:39       ` Andy Fleming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FA88A37.4040103@samsung.com \
    --to=jh80.chung@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox