From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jaehoon Chung Date: Tue, 08 May 2012 11:51:35 +0900 Subject: [U-Boot] [U-BOOT][PATCH] mmc: remove the hard setting for tran_speed In-Reply-To: References: <4F716933.4080006@samsung.com> Message-ID: <4FA88A37.4040103@samsung.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Andy. On 05/08/2012 06:50 AM, Andy Fleming wrote: > On Mon, Apr 2, 2012 at 1:31 PM, Jae hoon Chung wrote: > >>> if (mmc->card_caps & MMC_MODE_HS) { >>> if (mmc->card_caps & MMC_MODE_HS_52MHz) >>> - mmc_set_clock(mmc, 52000000); >>> + mmc->tran_speed = 52000000; >>> else >>> - mmc_set_clock(mmc, 26000000); >>> - } else >>> - mmc_set_clock(mmc, 20000000); >>> + mmc->tran_speed = 26000000; >>> + } > > > Why did you remove the outer else clause, here (the one that set the > speed to 20000000)? > If card->caps didn't set MMC_MODE_HS, then it's set to mmc->tran_speed. That value is assigned from freq * mult. I think that is reasonable..if set to 20000000 here, then why need freq & mult? Best Regards, Jaehoon Chung