From: Alexander Holler <holler@ahsoftware.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Ignore all Carriage Returns when importing an environment.
Date: Sat, 12 May 2012 20:33:53 +0200 [thread overview]
Message-ID: <4FAEAD11.5090400@ahsoftware.de> (raw)
In-Reply-To: <201205121808.54802.marex@denx.de>
Am 12.05.2012 18:08, schrieb Marek Vasut:
> Dear Alexander Holler,
>
>> Am 12.05.2012 16:46, schrieb Marek Vasut:
>>> Dear Alexander Holler,
>>>
>>>> Am 12.05.2012 08:17, schrieb Marek Vasut:
>>>>> Dear Alexander Holler,
>>>>>
>>>>>> This is used for compatibility with text files which are
>>>>>> using CRLF instead of LF as the end of a line.
>>>>>>
>>>>>> Signed-off-by: Alexander Holler<holler@ahsoftware.de>
>>>>>
>>>>> Why don't you run the file trough dos2unix or tr -d '\r' ?
>>>>
>>>> Because my files don't contain CRs. ;)
>>>
>>> s/you/someone else/ :)
>>
>> Try to explain a windows user that a text file should not contain
>> carriage returns and how he can achieve that.
>>
>> You'll do it once, maybe twice, than you will surrender. ;)
>
> But you're fixing the problem at a wrong place, aren't you? Besides, removing \r
> might harm some environments, don't you think?
No, there is no other layer between the user and that function.
Anyway, as already said, I don't care, just had this patch lying around
a year and I finally surrendered to post it here (in favor of those
users). But it seems I was right in not posting it. ;)
Regards,
Alexander
next prev parent reply other threads:[~2012-05-12 18:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-11 7:14 [U-Boot] [PATCH] Ignore all Carriage Returns when importing an environment Alexander Holler
2012-05-11 19:09 ` Wolfgang Denk
2012-05-12 14:22 ` Alexander Holler
2012-05-12 21:18 ` Wolfgang Denk
2012-05-13 8:07 ` Alexander Holler
2012-05-13 9:27 ` Wolfgang Denk
2012-05-12 6:17 ` Marek Vasut
2012-05-12 14:25 ` Alexander Holler
2012-05-12 14:46 ` Marek Vasut
2012-05-12 14:50 ` Alexander Holler
2012-05-12 16:08 ` Marek Vasut
2012-05-12 18:33 ` Alexander Holler [this message]
2012-05-12 18:37 ` Marek Vasut
2012-05-12 19:10 ` Alexander Holler
2012-05-12 21:21 ` Wolfgang Denk
2012-05-13 7:43 ` Alexander Holler
2012-05-12 21:19 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FAEAD11.5090400@ahsoftware.de \
--to=holler@ahsoftware.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox