[U-Boot] [PATCH 2/2] beagle: handle import of environments in files with CRLF as line endings

Alexander Holler
2012-05-13T18:58:44Z

On 13.05.2012 20:52, Marek Vasut wrote:
> Dear Alexander Holler,
>
>> On 13.05.2012 19:09, Marek Vasut wrote:
>>> Dear Alexander Holler,
>>>
>>>> Use the new option -r for env import.
>>>>
>>>> Signed-off-by: Alexander Holler<holler@ahsoftware.de>
>>>> ---
>>>>
>>>> include/configs/omap3_beagle.h | 2 +-
>>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>>>
>>>> diff --git a/include/configs/omap3_beagle.h
>>>> b/include/configs/omap3_beagle.h index ddeb414..d8b10c2 100644
>>>> --- a/include/configs/omap3_beagle.h
>>>> +++ b/include/configs/omap3_beagle.h
>>>> @@ -258,7 +258,7 @@
>>>>
>>>> "bootenv=uEnv.txt\0" \
>>>> "loadbootenv=fatload mmc ${mmcdev} ${loadaddr} ${bootenv}\0" \
>>>> "importbootenv=echo Importing environment from mmc ...; " \
>>>>
>>>> - "env import -t $loadaddr $filesize\0" \
>>>> + "env import -t -r $loadaddr $filesize\0" \
>>>
>>> Not everyone importing env on beagle use broken tools ;-)
>>
>> Who said that?
>
> You impose your -r option on all beagle users. That means everyone (even those
> with not-broken) tools will now use it (unless they replaced their env).

Yes, and now they all will get doomed by ignored CRs before LFs.

Anyway, just ignore those patches, it was lost time from the beginning
and I should have known it better.

Alexander