From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Weber Date: Tue, 15 May 2012 22:33:31 +0200 Subject: [U-Boot] [PATCH] UBIFS: Improve error message when reading superblock failed In-Reply-To: <1333367914-20461-1-git-send-email-weber@corscience.de> References: <4F4219F4.3080005@aribaud.net> <1333367914-20461-1-git-send-email-weber@corscience.de> Message-ID: <4FB2BD9B.1010303@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Ccing Albert Thomas On 04/02/2012 01:58 PM, Thomas Weber wrote: > From: Bernhard Walle > > In addition to the error message also display the error code. I had the > problem that my malloc memory was not enough (ENOMEM), and if u-boot > had displayed the error code immediately that would have saved me some > debugging. > > Signed-off-by: Bernhard Walle > > Use ubifs_err instead of printf. > Add "errno=%d" in output as suggested by Albert Aribaud. > Signed-off-by: Thomas Weber > --- > fs/ubifs/super.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c > index 26b48f0..30ccd98 100644 > --- a/fs/ubifs/super.c > +++ b/fs/ubifs/super.c > @@ -1191,7 +1191,7 @@ int ubifs_mount(char *vol_name) > mnt = NULL; > ret = ubifs_get_sb(&ubifs_fs_type, flags, name, data, mnt); > if (ret) { > - printf("Error reading superblock on volume '%s'!\n", name); > + ubifs_err("Error reading superblock on volume '%s' errno=%d!\n", name, ret); > return -1; > } >