From mboxrd@z Thu Jan  1 00:00:00 1970
From: Scott Wood <scottwood@freescale.com>
Date: Wed, 16 May 2012 11:02:24 -0500
Subject: [U-Boot] [PATCH V2 2/4] mtd/NAND: Add FSMC driver support
In-Reply-To: <4FB38454.3080803@st.com>
References: <cover.1336374946.git.amit.virdi@st.com>
	<9e312b0349ace0f0284be499a21ef1d7eb31e8a5.1336374946.git.amit.virdi@st.com>
	<4FB2C71A.3000208@freescale.com> <4FB38454.3080803@st.com>
Message-ID: <4FB3CF90.1000202@freescale.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 05/16/2012 05:41 AM, Amit Virdi wrote:
> Hi Scott,
> 
> On 5/16/2012 2:44 AM, Scott Wood wrote:
>> On 05/07/2012 02:26 AM, Amit Virdi wrote:
>>> +    while (num_err--) {
>>> +        change_bit(0,&err_idx[i]);
>>> +        change_bit(1,&err_idx[i]);
>>> +
>>> +        if (err_idx[i]<  512 * 8) {
>>> +            change_bit(err_idx[i], dat);
>>> +            i++;
>>> +        }
>>> +    }
>>
>> Is it normal to not count bit flips in the ECC itself?
>>
> 
> Correcting bit flip in ECC isn't of any use, so we skipped it.

I think it is useful to report that the bit flip happened, so that the
upper layers know when to scrub the page.

> Otherwise also, the ECC and the data area are not contiguous here as
> they are at different parts of RAM so we couldn't have done
>     if (err_idx[i]<  (512+13) * 8) {
> here.

You could still increment the error count.

-Scott