From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Ujfalusi Date: Thu, 17 May 2012 12:28:46 +0300 Subject: [U-Boot] [PATCH] sdp4430: fix mux configuration for SYS_NIRQ2 In-Reply-To: References: <1337244221-11655-1-git-send-email-peter.ujfalusi@ti.com> Message-ID: <4FB4C4CE.8090506@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Sricharan, On 05/17/2012 11:48 AM, R, Sricharan wrote: >> diff --git a/board/ti/sdp4430/sdp4430_mux_data.h b/board/ti/sdp4430/sdp4430_mux_data.h >> index 0a20968..beb7c7a 100644 >> --- a/board/ti/sdp4430/sdp4430_mux_data.h >> +++ b/board/ti/sdp4430/sdp4430_mux_data.h >> @@ -216,7 +216,7 @@ const struct pad_conf_entry core_padconf_array_non_essential[] = { >> {FREF_CLK1_OUT, (M0)}, /* fref_clk1_out */ >> {FREF_CLK2_OUT, (M0)}, /* fref_clk2_out */ >> {SYS_NIRQ1, (PTU | IEN | M0)}, /* sys_nirq1 */ >> - {SYS_NIRQ2, (M7)}, /* sys_nirq2 */ >> + {SYS_NIRQ2, (PTU | IEN | M0)}, /* sys_nirq2 */ > > Looks fine. But how about doing this in the kernel using mux framework? The SYS_NIRQ2 has been configured correctly in case of PandaBoard in u-boot. Looking at the kernel: neither of the sdp4430 or PandaBoard board files are configuring SYS_NIRQ1/2, all relies on the bootloader to set this up. I can as well send patches for sdp4430 and PandaBoard board files to configure the SYS_NIRQ2 explicitly, but IMHO the bootloader can do this for us with ease as well. I think if we can we should set up things in a bootloader and let the kernel to deal with smaller differences (like things differs between board revisions and stuff). Regards, P?ter