[U-Boot] [PATCH 5/6] cmd_nvedit.c: allow board-specific code before/after saving the environment

Scott Wood
2012-05-18T16:13:30Z

On 05/18/2012 11:00 AM, Timur Tabi wrote:
> Scott Wood wrote:
>>> There's no NAND support at all.
>> Of course there's NAND support. I was asking what, besides the mux,
>> makes that existing support not work on this board.
>
> No, there is no NAND support for the P1022DS upstream.
>
> [b04825 at efes u-boot.0]$ grep -i nand include/configs/P1022DS.h
> [b04825 at efes u-boot.0]$

That's the equivalent of saying Linux doesn't support something because
nobody bothered to enable it in a certain defconfig.

>>>> However, I just tried the two SDK patches
>>>> that add it, and they apply cleanly, so that's an easy fix.
>> Which patches are those?
>
> powerpc/85xx: add SPI and SD builds for P1022DS
> powerpc/p1022ds: Add support for NAND and NAND boot

I'm not sure what SPI and SD have to do with it...

Most of the latter patch is concerned with NAND boot, which is a
different issue from NAND support, but still pretty important if you're
going NAND-only. It looks like the patches were actually initially
separate, but Kumar oh-so-helpfully squashed them together.

One thing I would like to see fixed in at upstream version of p1022ds
NAND boot support is for it to use SPD like a normal p1022ds boot. This
will likely require reviving the three-stage boot discussion (TPL).

-Scott