[U-Boot] [PATCH 5/6] cmd_nvedit.c: allow board-specific code before/after saving the environment

Scott Wood
2012-05-17T22:48:24Z

On 05/17/2012 05:18 PM, Wolfgang Denk wrote:
> Dear Timur Tabi,
>
> In message <4FB12E88.1050906@freescale.com> you wrote:
>>
>>> all these board hooks are paper-cutting us to death with unused bloat
>>
>> I know, and I don't like it either. I hate how our hardware designers are
>> always breaking the "rules", forcing us software developers to hack up our
>> software more and more. The muxing on this chip is a like a cruel joke
>> being played on me. I've even been told that I'm trying too hard to make
>> it work.
>
> I think whoever told you this was right. Let it break.
>
> We cannot add pre- and post-hooks all ever the place for brain-dead
> designs that need to do this and that before and after doing perfectly
> things.
>
> It makes no sense adding this to saveenv, because there will be othe
> rplaces in the code that need to to the same - like if it's NAND
> flash, you will probabaly need to do the same for all NAND related
> commands.

NAND doesn't need it because NAND goes through an API rather than direct
memory-mapped access, and has more coarse-grained operations. NAND
should be able to take care of this entirely in the driver using the
select_chip() callback.

Timur, is there any reason to use NOR rather than NAND with this chip?

-Scott