[U-Boot] [PATCH 5/6] cmd_nvedit.c: allow board-specific code before/after saving the environment

Timur Tabi
2012-05-18T16:17:38Z

Scott Wood wrote:

> That's the equivalent of saying Linux doesn't support something because
> nobody bothered to enable it in a certain defconfig.

Well, that's exactly what I meant. When you boot an upstream U-boot on a
P1022DS, there is no support for NAND chips. The 'nand' command does not
exist. You cannot build a u-boot.bin that will boot from NAND. That
pretty much means "there is no NAND support".

>>>>> However, I just tried the two SDK patches
>>>>> that add it, and they apply cleanly, so that's an easy fix.
>>> Which patches are those?
>>
>> powerpc/85xx: add SPI and SD builds for P1022DS
>> powerpc/p1022ds: Add support for NAND and NAND boot
>
> I'm not sure what SPI and SD have to do with it...

The 2nd patch applies on top of the first.

> Most of the latter patch is concerned with NAND boot, which is a
> different issue from NAND support, but still pretty important if you're
> going NAND-only. It looks like the patches were actually initially
> separate, but Kumar oh-so-helpfully squashed them together.

It's a good thing we don't do that any more.

> One thing I would like to see fixed in at upstream version of p1022ds
> NAND boot support is for it to use SPD like a normal p1022ds boot. This
> will likely require reviving the three-stage boot discussion (TPL).

I just posted those two patches for upstream. I don't want the TPL work
to hold up these patches.

--
Timur Tabi
Linux kernel developer at Freescale