[U-Boot] [PATCH 5/6] cmd_nvedit.c: allow board-specific code before/after saving the environment

Wolfgang Denk
2012-05-17T22:18:07Z

Dear Timur Tabi,

In message <4FB12E88.1050906@freescale.com> you wrote:
>
> > all these board hooks are paper-cutting us to death with unused bloat
>
> I know, and I don't like it either. I hate how our hardware designers are
> always breaking the "rules", forcing us software developers to hack up our
> software more and more. The muxing on this chip is a like a cruel joke
> being played on me. I've even been told that I'm trying too hard to make
> it work.

I think whoever told you this was right. Let it break.

We cannot add pre- and post-hooks all ever the place for brain-dead
designs that need to do this and that before and after doing perfectly
things.

It makes no sense adding this to saveenv, because there will be othe
rplaces in the code that need to to the same - like if it's NAND
flash, you will probabaly need to do the same for all NAND related
commands.

cmd_nvedit.c is definitely the wrong place for this.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Bradley's Bromide: If computers get too powerful, we can organize
them into a committee - that will do them in.