public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3] Correct corrupted NAND Flash access on KARO TX25 modules
Date: Fri, 18 May 2012 17:52:21 -0500	[thread overview]
Message-ID: <4FB6D2A5.3000203@freescale.com> (raw)
In-Reply-To: <7605B15734F74B40A124AED46B25250A4F2D6F@HEFRMBX01.sofr.hefr.lan>

On 04/06/2012 04:22 PM, Gachet Daniel wrote:
> Hi Stefano,
> 
> You will find below the new patch for the NAND flash access problem on the TX25 module.
> I hope this version is fulfilling your expectations.
> 
> Cordially,
> 
> Daniel 
> 
> diff --git a/drivers/mtd/nand/mxc_nand.c b/drivers/mtd/nand/mxc_nand.c
> index 35e89a0..fe1cef6 100644
> --- a/drivers/mtd/nand/mxc_nand.c
> +++ b/drivers/mtd/nand/mxc_nand.c
> @@ -1290,7 +1290,9 @@ static void mxc_setup_config1(void)
>  	uint16_t tmp;
>  
>  	tmp = readw(&host->regs->nfc_config1);
> +#ifndef CONFIG_NAND_MXC_NFC_TWO_CYCLES
>  	tmp |= NFC_ONE_CYCLE;
> +#endif
>  	tmp |= NFC_4_8N_ECC;
>  	writew(tmp, &host->regs->nfc_config1);
>  	if (host->pagesize_2k)
> diff --git a/include/configs/tx25.h b/include/configs/tx25.h
> index 87bd8a6..0c9aeb8 100644
> --- a/include/configs/tx25.h
> +++ b/include/configs/tx25.h
> @@ -110,6 +110,7 @@
>  /* NAND */
>  #define CONFIG_NAND_MXC
>  #define CONFIG_NAND_MXC_V1_1
> +#define CONFIG_NAND_MXC_NFC_TWO_CYCLES
>  #define CONFIG_MXC_NAND_REGS_BASE	(0xBB000000)
>  #define CONFIG_SYS_MAX_NAND_DEVICE	1
>  #define CONFIG_SYS_NAND_BASE		(0xBB000000)

Please add documentation for this new config option -- also it should be
CONFIG_SYS as it is hardware description rather than configuration.

-Scott

      reply	other threads:[~2012-05-18 22:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-06 21:22 [U-Boot] [PATCH v3] Correct corrupted NAND Flash access on KARO TX25 modules Gachet Daniel
2012-05-18 22:52 ` Scott Wood [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FB6D2A5.3000203@freescale.com \
    --to=scottwood@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox