* [U-Boot] [PATCH v3] Correct corrupted NAND Flash access on KARO TX25 modules
@ 2012-04-06 21:22 Gachet Daniel
2012-05-18 22:52 ` Scott Wood
0 siblings, 1 reply; 2+ messages in thread
From: Gachet Daniel @ 2012-04-06 21:22 UTC (permalink / raw)
To: u-boot
Hi Stefano,
You will find below the new patch for the NAND flash access problem on the TX25 module.
I hope this version is fulfilling your expectations.
Cordially,
Daniel
diff --git a/drivers/mtd/nand/mxc_nand.c b/drivers/mtd/nand/mxc_nand.c
index 35e89a0..fe1cef6 100644
--- a/drivers/mtd/nand/mxc_nand.c
+++ b/drivers/mtd/nand/mxc_nand.c
@@ -1290,7 +1290,9 @@ static void mxc_setup_config1(void)
uint16_t tmp;
tmp = readw(&host->regs->nfc_config1);
+#ifndef CONFIG_NAND_MXC_NFC_TWO_CYCLES
tmp |= NFC_ONE_CYCLE;
+#endif
tmp |= NFC_4_8N_ECC;
writew(tmp, &host->regs->nfc_config1);
if (host->pagesize_2k)
diff --git a/include/configs/tx25.h b/include/configs/tx25.h
index 87bd8a6..0c9aeb8 100644
--- a/include/configs/tx25.h
+++ b/include/configs/tx25.h
@@ -110,6 +110,7 @@
/* NAND */
#define CONFIG_NAND_MXC
#define CONFIG_NAND_MXC_V1_1
+#define CONFIG_NAND_MXC_NFC_TWO_CYCLES
#define CONFIG_MXC_NAND_REGS_BASE (0xBB000000)
#define CONFIG_SYS_MAX_NAND_DEVICE 1
#define CONFIG_SYS_NAND_BASE (0xBB000000)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [U-Boot] [PATCH v3] Correct corrupted NAND Flash access on KARO TX25 modules
2012-04-06 21:22 [U-Boot] [PATCH v3] Correct corrupted NAND Flash access on KARO TX25 modules Gachet Daniel
@ 2012-05-18 22:52 ` Scott Wood
0 siblings, 0 replies; 2+ messages in thread
From: Scott Wood @ 2012-05-18 22:52 UTC (permalink / raw)
To: u-boot
On 04/06/2012 04:22 PM, Gachet Daniel wrote:
> Hi Stefano,
>
> You will find below the new patch for the NAND flash access problem on the TX25 module.
> I hope this version is fulfilling your expectations.
>
> Cordially,
>
> Daniel
>
> diff --git a/drivers/mtd/nand/mxc_nand.c b/drivers/mtd/nand/mxc_nand.c
> index 35e89a0..fe1cef6 100644
> --- a/drivers/mtd/nand/mxc_nand.c
> +++ b/drivers/mtd/nand/mxc_nand.c
> @@ -1290,7 +1290,9 @@ static void mxc_setup_config1(void)
> uint16_t tmp;
>
> tmp = readw(&host->regs->nfc_config1);
> +#ifndef CONFIG_NAND_MXC_NFC_TWO_CYCLES
> tmp |= NFC_ONE_CYCLE;
> +#endif
> tmp |= NFC_4_8N_ECC;
> writew(tmp, &host->regs->nfc_config1);
> if (host->pagesize_2k)
> diff --git a/include/configs/tx25.h b/include/configs/tx25.h
> index 87bd8a6..0c9aeb8 100644
> --- a/include/configs/tx25.h
> +++ b/include/configs/tx25.h
> @@ -110,6 +110,7 @@
> /* NAND */
> #define CONFIG_NAND_MXC
> #define CONFIG_NAND_MXC_V1_1
> +#define CONFIG_NAND_MXC_NFC_TWO_CYCLES
> #define CONFIG_MXC_NAND_REGS_BASE (0xBB000000)
> #define CONFIG_SYS_MAX_NAND_DEVICE 1
> #define CONFIG_SYS_NAND_BASE (0xBB000000)
Please add documentation for this new config option -- also it should be
CONFIG_SYS as it is hardware description rather than configuration.
-Scott
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-05-18 22:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-06 21:22 [U-Boot] [PATCH v3] Correct corrupted NAND Flash access on KARO TX25 modules Gachet Daniel
2012-05-18 22:52 ` Scott Wood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox