From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] tegra: add alternate UART1 funcmux entry
Date: Mon, 21 May 2012 20:49:31 -0600 [thread overview]
Message-ID: <4FBAFEBB.7050200@wwwdotorg.org> (raw)
In-Reply-To: <CAPnjgZ2Lux+tt-v6nk-qzbD=zYMfy9BTCjY-dSA1e8hWf7PDMA@mail.gmail.com>
On 05/21/2012 06:47 PM, Simon Glass wrote:
> Hi Stephen,
>
> On Mon, May 14, 2012 at 4:13 PM, Stephen Warren <swarren@wwwdotorg.org
> <mailto:swarren@wwwdotorg.org>> wrote:
>
> From: Stephen Warren <swarren at nvidia.com <mailto:swarren@nvidia.com>>
>
> (In at least some configurations) Whistler uses UART1 on pingroups
> UAA, UAB.
> diff --git a/arch/arm/cpu/armv7/tegra2/board.c
> +static int uart_configs[] = {
> +#ifdef CONFIG_TEGRA2_UARTA_UAA_UAB
> + FUNCMUX_UART1_UAA_UAB,
> +#else
> + FUNCMUX_UART1_IRRX_IRTX,
> +#endif
>
>
> We really shouldn't be using configs to deal with this. It should be a
> run-time check.
>
> I recall you saying that we could use the ODM bits for this?
The ODM bits can indicate which UART is to be used to the debug serial
port, but not the pinmux options. We have no alternative but to make
this a compile-time constant.
>
> + FUNCMUX_UART2_IRDA,
> + -1,
> + FUNCMUX_UART4_GMC,
> + -1,
> +};
next prev parent reply other threads:[~2012-05-22 2:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-14 23:13 [U-Boot] [PATCH 1/2] tegra: add alternate UART1 funcmux entry Stephen Warren
2012-05-14 23:13 ` [U-Boot] [PATCH 2/2] tegra: Whistler board support Stephen Warren
2012-05-15 15:07 ` [U-Boot] [PATCH 1/2] tegra: add alternate UART1 funcmux entry Lucas Stach
2012-05-22 0:47 ` Simon Glass
2012-05-22 2:49 ` Stephen Warren [this message]
2012-05-31 22:27 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBAFEBB.7050200@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox