From: Jorgen Lundman <lundman@lundman.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] EXT4
Date: Tue, 22 May 2012 14:55:57 +0900 [thread overview]
Message-ID: <4FBB2A6D.80403@lundman.net> (raw)
In-Reply-To: <CALButCL9ie5So=rxyDdtOM8D64_oK-xZ1ZDetbM_44DFjCwHcA@mail.gmail.com>
> Yes, that is exactly what you should do.
>
> But before you post them, make sure you run them through checkpatch.pl
> first and resolve/explain any errors or warnings
Wow, ohhweee this will take a little while.
How set in stone is the output of checkpatch.pl ? Specifically;
ERROR: do not initialise globals to 0 or NULL
#596: FILE: fs/zfs/zfs.c:33:
+block_dev_desc_t *zfs_dev_desc = NULL;
That strikes me as dangerous. One lets you fail gracefully (Sorry, X has
not been initialised) and the other is just a plain crash. I find crashes
to be very ugly, even if it is only reachable by other developers.
WARNING: do not add new typedefs
#728: FILE: fs/zfs/zfs.c:165:
+typedef struct decomp_entry
I'm seriously not allowed to make new typedefs? ouch.
So yeah, should it always pass without a single problem, or may I employ
some measure of moderation?
--
Jorgen Lundman | <lundman@lundman.net>
Unix Administrator | +81 (0)3 -5456-2687 ext 1017 (work)
Shibuya-ku, Tokyo | +81 (0)90-5578-8500 (cell)
Japan | +81 (0)3 -3375-1767 (home)
next prev parent reply other threads:[~2012-05-22 5:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-22 3:31 [U-Boot] [PATCH] EXT4 Jorgen Lundman
2012-05-22 3:36 ` Graeme Russ
2012-05-22 3:45 ` Jorgen Lundman
2012-05-22 3:50 ` Graeme Russ
2012-05-22 5:55 ` Jorgen Lundman [this message]
2012-05-22 6:05 ` Stefan Kristiansson
2012-05-22 6:06 ` Graeme Russ
2012-05-22 6:17 ` Jorgen Lundman
2012-05-22 6:26 ` Graeme Russ
2012-05-22 8:33 ` Wolfgang Denk
2012-05-22 8:30 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBB2A6D.80403@lundman.net \
--to=lundman@lundman.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox