public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/5]: Correct i2c support on am33xx
Date: Tue, 22 May 2012 09:29:11 +0200	[thread overview]
Message-ID: <4FBB4047.3060705@denx.de> (raw)
In-Reply-To: <1337618793-13934-1-git-send-email-trini@ti.com>

Hello Tom,

Tom Rini wrote:
> The following series corrects i2c support for the am33xx family of devices
> (including beaglebone) and has been tested on a beagleboard xM and
> pandaboard.  I would like to take these changes in via the u-boot-ti tree
> as it's mostly changes to arch and board files but I've cc'd Heiko on the
> i2c related parts.  The biggest change here is to revert a previous change
> to the omap24xx_i2c.c driver for the i2c probe function.  In short, the
> change made before violated the TRM constraints but did no harm on the IP
> block found in omap3/related boards.  Moving forward to the IP block found
> on omap4 and am33xx (and others) it still voilates the TRM and now leaves
> the bus in an unboundedly defined state like the TRM states.  We must
> revert this change for both correctness and functionality.  The rest of the
> series is minor corrections to structs/defines and adding CONFIG_AM33XX to
> the block of !CONFIG_OMAP2430.  I've thought of, but think it should be
> separate to change omap24xx_i2c.c to test for CONFIG_OMAP2430 rather than
> every other present and future user in a few areas.

Ok, just saw, that you delegate this patches in patchwork to you.
I am fine with that, but want to ack this patches, so please wait
until I sent my Ack ... thanks!

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de

      parent reply	other threads:[~2012-05-22  7:29 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-21 16:46 [U-Boot] [PATCH 0/5]: Correct i2c support on am33xx Tom Rini
2012-05-21 16:46 ` [U-Boot] [PATCH 1/5] Revert "I2C: OMAP: detect more devices when probing an i2c bus" Tom Rini
2012-05-22 12:11   ` Heiko Schocher
2012-05-21 16:46 ` [U-Boot] [PATCH 2/5] am335x: Correct i2c sysc offset Tom Rini
2012-05-22 12:11   ` Heiko Schocher
2012-05-21 16:46 ` [U-Boot] [PATCH 3/5] am33xx: Fill in more cm_wkuppll / cm_perpll Tom Rini
2012-05-22 12:12   ` Heiko Schocher
2012-05-21 16:46 ` [U-Boot] [PATCH 4/5] am33xx: Fix i2c sampling rate typo Tom Rini
2012-05-22 12:12   ` Heiko Schocher
2012-05-21 16:46 ` [U-Boot] [PATCH 5/5] omap24xx_i2c: Add AM33XX support Tom Rini
2012-05-22 12:12   ` Heiko Schocher
2012-05-22  7:29 ` Heiko Schocher [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FBB4047.3060705@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox