From: Amit Virdi <amit.virdi@st.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V4 1/4] ARM: Define change_bit routine
Date: Tue, 22 May 2012 15:44:42 +0530 [thread overview]
Message-ID: <4FBB6712.3040005@st.com> (raw)
In-Reply-To: <4FB66E11.50003@freescale.com>
>>
>> extern void clear_bit(int nr, volatile void * addr);
>>
>> -extern void change_bit(int nr, volatile void * addr);
>> -
>> static inline void __change_bit(int nr, volatile void *addr)
>> {
>> unsigned long mask = BIT_MASK(nr);
>> @@ -39,6 +37,11 @@ static inline void __change_bit(int nr, volatile void *addr)
>> *p ^= mask;
>> }
>>
>> +static inline void change_bit(int nr, volatile void *addr)
>> +{
>> + __change_bit(nr, addr);
>> +}
>> +
>> static inline int __test_and_set_bit(int nr, volatile void *addr)
>> {
>> unsigned long mask = BIT_MASK(nr);
>
> While they're not used much, U-Boot does have interrupt support (at
> least on powerpc -- not sure about ARM), so this should be atomic
> against interrupts.
>
> The NAND driver should be using __change_bit() instead.
>
Alright, I shall be soon sending V5 that drops this patch and uses
__change_bit directly.
Thanks
Amit Virdi
next prev parent reply other threads:[~2012-05-22 10:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-18 6:00 [U-Boot] [PATCH V4 0/4] mtd/NAND: Support for FSMC controller Amit Virdi
2012-05-18 6:00 ` [U-Boot] [PATCH V4 1/4] ARM: Define change_bit routine Amit Virdi
2012-05-18 15:43 ` Scott Wood
2012-05-22 10:14 ` Amit Virdi [this message]
2012-05-22 15:51 ` Wolfgang Denk
2012-05-24 4:18 ` Amit Virdi
2012-05-18 6:00 ` [U-Boot] [PATCH V4 2/4] mtd/NAND: Add FSMC driver support Amit Virdi
2012-05-18 6:00 ` [U-Boot] [PATCH V4 3/4] SPEAr: Configure FSMC driver for NAND interface Amit Virdi
2012-05-18 6:00 ` [U-Boot] [PATCH V4 4/4] mtd/NAND: Remove obsolete SPEAr specific NAND drivers Amit Virdi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBB6712.3040005@st.com \
--to=amit.virdi@st.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox