From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Tue, 22 May 2012 10:16:12 -0600 Subject: [U-Boot] [PATCH V2 1/2] Add env vars describing U-Boot target board In-Reply-To: <20120522082356.5C78C200239@gemini.denx.de> References: <1337643054-17290-1-git-send-email-swarren@wwwdotorg.org> <20120522082356.5C78C200239@gemini.denx.de> Message-ID: <4FBBBBCC.5020309@wwwdotorg.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 05/22/2012 02:23 AM, Wolfgang Denk wrote: > Dear Stephen Warren, > > In message <1337643054-17290-1-git-send-email-swarren@wwwdotorg.org> you wrote: >> From: Stephen Warren >> >> This can be useful for generic scripts. For example, rather than hard- >> coding a script to ext2load tegra-harmony.dtb, it could load >> ${soc}-${board}.dtb and hence not need adjustments to run on multiple >> boards. > ... > >> +echo "#define ARCH \"${arch}\"" >> config.h >> +echo "#define CPU \"${cpu}\"" >> config.h >> +echo "#define BOARD \"${board}\"" >> config.h > > Sorry, but names like ARCH and CPU are _way_ too intrusive and likely > to clash. Please use something like CONFIG_SYS_ARCH_NAME etc. > instead. OK. Are you OK with the environment variable names? They're also common names like arch, cpu, board, vendor, soc.