From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Tue, 22 May 2012 10:58:37 -0600 Subject: [U-Boot] [PATCH] tegra: paz00: add device tree support In-Reply-To: <4FBBBB83.1080106@wwwdotorg.org> References: <1337630677-26390-1-git-send-email-swarren@wwwdotorg.org> <2896820.zSgpRH4SO8@fb07-iapwap2> <4FBBBB83.1080106@wwwdotorg.org> Message-ID: <4FBBC5BD.7080107@wwwdotorg.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 05/22/2012 10:14 AM, Stephen Warren wrote: > On 05/22/2012 02:04 AM, Marc Dietrich wrote: >> Hi Stephen, >> >> Am Montag, 21. Mai 2012, 14:04:37 schrieb Stephen Warren: >>> From: Stephen Warren >>> >>> ... to enable USB host support, which enables Ethernet support. >>> >>> Signed-off-by: Stephen Warren >> >> while adding usb support is fine, I see no reason to add smsc95xx support >> because contrary to harmony, paz00 does not contain an ethernet port. > > Is the SMSC95xx only an internal part, or could it be present on a > user-pluggable USB dongle? I wasn't sure, so I left it in. Looking at the driver (and the Linux kernel driver and SMSC's website), it supports both the standalone USB->Ethernet 9500 chip that's likely to be in USB Ethernet dongles, and various combo USB hub + Ethernet chips that are found on motherboards (e.g. Harmony). As such, I think it's reasonable to leave this config option enabled on Paz00 and other Tegra boards even when such a chip isn't on the board itself. Do you agree?