From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] tegra: paz00: add device tree support
Date: Tue, 22 May 2012 16:30:29 -0600 [thread overview]
Message-ID: <4FBC1385.6070002@wwwdotorg.org> (raw)
In-Reply-To: <2678138.iKi0Ts4yfH@ax5200p>
On 05/22/2012 03:15 PM, Marc Dietrich wrote:
> On Tuesday 22 May 2012 10:58:37 Stephen Warren wrote:
>> On 05/22/2012 10:14 AM, Stephen Warren wrote:
>>> On 05/22/2012 02:04 AM, Marc Dietrich wrote:
>>>> Hi Stephen,
>>>>
>>>> Am Montag, 21. Mai 2012, 14:04:37 schrieb Stephen Warren:
>>>>> From: Stephen Warren <swarren@nvidia.com>
>>>>>
>>>>> ... to enable USB host support, which enables Ethernet support.
>>>>>
>>>>> Signed-off-by: Stephen Warren <swarren@nvidia.com>
>>>>
>>>> while adding usb support is fine, I see no reason to add smsc95xx support
>>>> because contrary to harmony, paz00 does not contain an ethernet port.
>>>
>>> Is the SMSC95xx only an internal part, or could it be present on a
>>> user-pluggable USB dongle? I wasn't sure, so I left it in.
>>
>> Looking at the driver (and the Linux kernel driver and SMSC's website),
>> it supports both the standalone USB->Ethernet 9500 chip that's likely to
>> be in USB Ethernet dongles, and various combo USB hub + Ethernet chips
>> that are found on motherboards (e.g. Harmony). As such, I think it's
>> reasonable to leave this config option enabled on Paz00 and other Tegra
>> boards even when such a chip isn't on the board itself. Do you agree?
>
> Following this argument would mean to enable all current (and future) usb
> devices and we end up with an u-boot which is to heavy to swim. I only have a
> mcs7830 which is unfortunately not supported. Do you have a SMSC95xx based usb
> adapter or plan to get one? In this case I think it would be ok to enable it,
> otherwise I tend to disagree here. On the other hand, given that you kindly
> take care of the paz00 code, the decision is up to you.
Mine is an Asix-based dongle.
It seems a pity to artificially limit ourselves. I'd be happy seeing all
the USB devices enabled as the drivers are written myself.
But I suppose net-booting is a developer thing, and developers can
easily turn on this option if they want, so I can remove it.
Is your objection for the Paz00 board only? I turned it on for all the
other boards too. Note that Harmony really does have this chip on the
board, so would need this option enabled either way.
next prev parent reply other threads:[~2012-05-22 22:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-21 20:04 [U-Boot] [PATCH] tegra: paz00: add device tree support Stephen Warren
2012-05-22 8:04 ` Marc Dietrich
2012-05-22 16:14 ` Stephen Warren
2012-05-22 16:58 ` Stephen Warren
2012-05-22 21:15 ` Marc Dietrich
2012-05-22 22:30 ` Stephen Warren [this message]
2012-05-23 12:16 ` Marc Dietrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBC1385.6070002@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox