[U-Boot] [PATCH v4 5/6] omap4+: Avoid using __attribute__ ((__packed__))

Aneesh V
2012-03-08T17:20:21Z

Avoid using __attribute__ ((__packed__)) unless it's
absolutely necessary. "packed" will remove alignment
requirements for the respective objects and may cause
alignment issues unless alignment is also enforced
using a pragma.

Here, these packed attributes were causing alignment
faults in Thumb build.

Signed-off-by: Aneesh V <aneesh@ti.com>
---

Changes in v4:
- None

Changes in v3:
- Newly added
---
arch/arm/include/asm/arch-omap4/mux_omap4.h | 2 +-
arch/arm/include/asm/arch-omap5/mux_omap5.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/include/asm/arch-omap4/mux_omap4.h b/arch/arm/include/asm/arch-omap4/mux_omap4.h
index 30bfad7..4de7c70 100644
--- a/arch/arm/include/asm/arch-omap4/mux_omap4.h
+++ b/arch/arm/include/asm/arch-omap4/mux_omap4.h
@@ -34,7 +34,7 @@ struct pad_conf_entry {

u16 val;

-} __attribute__ ((packed));
+};

#ifdef CONFIG_OFF_PADCONF
#define OFF_PD (1 << 12)
diff --git a/arch/arm/include/asm/arch-omap5/mux_omap5.h b/arch/arm/include/asm/arch-omap5/mux_omap5.h
index b8c2185..af6874f 100644
--- a/arch/arm/include/asm/arch-omap5/mux_omap5.h
+++ b/arch/arm/include/asm/arch-omap5/mux_omap5.h
@@ -34,7 +34,7 @@ struct pad_conf_entry {

u16 val;

-} __attribute__ ((__packed__));
+};

#ifdef CONFIG_OFF_PADCONF
#define OFF_PD (1 << 12)
--
1.7.1