public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 5/7] OMAP5: EMIF: Add support for DDR3 device
Date: Wed, 23 May 2012 09:55:40 -0700	[thread overview]
Message-ID: <4FBD168C.4080403@ti.com> (raw)
In-Reply-To: <CAJ7qFSfAc2q+zt+11GLciE8Hp3MhVaPEo7opvCU7hxriaLxpUQ@mail.gmail.com>

On 05/23/2012 05:22 AM, R, Sricharan wrote:
> Hi Tom,
>>>
>>>   ah, this is what is there on OMAP5.
>>>     3 for DDR3
>>>     4 for LPDDR2-S4,
>>>     5 for LPDDR2-S2
>>
>>
>> 4/5 are listed as reserved here :( http://www.ti.com/lit/pdf/spruh73
>>
>>
>>> Atleast DDR3 encoding is same. So we can differentiate bw DDR3 and 2
>>> in same way.
>>> Is the reset value set correctly on am335x according to the device
>>> connected?
>>
>>
>> I'll have to do some checking as the code doesn't check that today.
>>
>   The reset value reflects the connected device correctly for lpddr2 and ddr3.
>   Is that the same case in am33xx platforms  ?

Yes, it's 3 on DDR3 and 2 on (non-LP) DDR2.  I spent some time yesterday 
starting on splitting up emif-common (am33xx does not have DMM) and 
making am33xx link at least with the common code.  My idea is to add a 
few more defines and make that part of do_sdram_init be:
if (!in_sdram) {
   switch(reg_sdram_type) {
#ifdef CONFIG_EMIF4_DDR2
     case 2:
       ddr2_init();
       break;
#ifdef CONFIG_EMFI4_DDR3
     case 3:
       ddr3_init();
       break;
#endif
#ifdef CONFIG_EMIF4_LPDDR2
     case 4:
     case 5:
       lpddr2_init();
       break;
#endif
     default:
       panic("Unsupported DDR type connected to EMIF4");
   }
}

And move lpddr2_init to emif4-lpddr2.c, and so forth.  My experimenting 
yesterday lead me to conclude that EMIF_MOD_ID_REGISTER behaves as is 
documented for am33xx on omap4/5 so what we're doing should be feasible. 
  I'm going to try and locally make the ddr3 patches work on the am33xx 
DDR3 board as a way to prove that out and if it works, and we're fine 
with what I've laid out above, start working towards that layout.

-- 
Tom

  reply	other threads:[~2012-05-23 16:55 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-22 10:03 [U-Boot] [PATCH 0/7] OMAP5: Add support for OMAP5432 SOC Lokesh Vutla
2012-05-22 10:03 ` [U-Boot] [PATCH 1/7] OMAP5: Adding correct Control id code for OMAP5430 Lokesh Vutla
2012-05-22 10:24   ` R, Sricharan
2012-05-22 10:03 ` [U-Boot] [PATCH 2/7] OMAP5: ADD chip detection for OMAP5432 SOC Lokesh Vutla
2012-05-22 10:03 ` [U-Boot] [PATCH 3/7] OMAP5: Configure the io settings for omap5432 uevm board Lokesh Vutla
2012-05-22 10:03 ` [U-Boot] [PATCH 4/7] OMAP5: ADD precalculated timings for ddr3 Lokesh Vutla
2012-05-22 10:31   ` R, Sricharan
2012-05-22 10:03 ` [U-Boot] [PATCH 5/7] OMAP5: EMIF: Add support for DDR3 device Lokesh Vutla
2012-05-22 14:41   ` Tom Rini
2012-05-22 14:58     ` R, Sricharan
2012-05-22 15:18       ` Tom Rini
2012-05-22 15:27         ` R, Sricharan
2012-05-22 15:39           ` Tom Rini
2012-05-23 12:22             ` R, Sricharan
2012-05-23 16:55               ` Tom Rini [this message]
2012-05-24  6:45                 ` R, Sricharan
2012-05-24 13:46                   ` Tom Rini
2012-05-22 10:03 ` [U-Boot] [PATCH 6/7] OMAP5: DPLL core lock for OMAP5432 Lokesh Vutla
2012-05-22 10:36   ` R, Sricharan
2012-05-22 10:03 ` [U-Boot] [PATCH 7/7] OMAP5: Change voltages for omap5432 Lokesh Vutla
2012-05-25 15:04 ` [U-Boot] [PATCH 0/7] OMAP5: Add support for OMAP5432 SOC Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FBD168C.4080403@ti.com \
    --to=trini@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox