From mboxrd@z Thu Jan  1 00:00:00 1970
From: Amit Virdi <amit.virdi@st.com>
Date: Thu, 24 May 2012 09:48:14 +0530
Subject: [U-Boot] [PATCH V4 1/4] ARM: Define change_bit routine
In-Reply-To: <20120522155100.1382F20716D@gemini.denx.de>
References: <cover.1337320290.git.amit.virdi@st.com>
	<cbe6d45427797fa5f4f8ef493006a5d7676e935d.1337320291.git.amit.virdi@st.com>
	<4FB66E11.50003@freescale.com> <4FBB6712.3040005@st.com>
	<20120522155100.1382F20716D@gemini.denx.de>
Message-ID: <4FBDB686.30908@st.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Wolfgang,

On 5/22/2012 9:21 PM, Wolfgang Denk wrote:
> Dear Amit Virdi,
>
> In message<4FBB6712.3040005@st.com>  you wrote:
>>
>> Alright, I shall be soon sending V5 that drops this patch and uses
>> __change_bit directly.
>
> It would be a much better investment in time if you come up with
> patches that help to _avoid_ usign this horrible function, and
> eventually removig it from U-Boot.
>
> change_bit() is inherently not portable and actual behaviour is
> largely undefined, so please do NOT use this function in any new code.
>

Ok. I have understood your point. I would resend V5 excluding any call 
to __change_bit.

Thanks
Amit Virdi