From: Holger Brunck <holger.brunck@keymile.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 25/27] arm/km: implement weak function board_spi_clam_bus/release
Date: Thu, 24 May 2012 17:54:10 +0200 [thread overview]
Message-ID: <4FBE59A2.2090401@keymile.com> (raw)
In-Reply-To: <F766E4F80769BD478052FB6533FA745D1A2FB28A3A@SC-VEXCH4.marvell.com>
Hi Prafulla,
On 05/24/2012 10:46 AM, Prafulla Wadaskar wrote:
>> - kwmpp_config[2] = MPP2_NF_IO4;
>> - kwmpp_config[3] = MPP3_NF_IO5;
>> - }
>> -
>> - /* Multi-Purpose Pins Functionality configuration */
>> - kirkwood_mpp_conf(kwmpp_config);
>> - kw_gpio_set_value(KM_FLASH_GPIO_PIN, gpio_value);
>> + kw_gpio_set_value(KM_FLASH_GPIO_PIN, 0);
>>
>> return 0;
>> }
>>
>> +void board_spi_release_bus(struct spi_slave *slave)
>> +{
>> + kw_gpio_set_value(KM_FLASH_GPIO_PIN, 1);
>> +}
>> +
>
> Sorry, I didn't understand.
> BTW: Why this is needed from SPI context?
>
> Please let's converge on SPI patches first and then send the rest of the dependent patch series, or exclude the SPI related changes for this patch series
>
> I will suggest to post smaller patch series targeting -
> 1. bug fixes to the current supported boards, that will go fast in.
> 2. SPI clam/release mpp patches
> 3. New board supports
>
the whole SPI stuff will be answered from Valentin when he is back next week.
What I could do to proceed with this patch series is to extract the bugfixes and
small reworks which are preparations for the new boards in a single patch serie
tomorrow that we can go ahead here.
This would be patches 01-09 from this serie. Ok?
Regards
Holger
next prev parent reply other threads:[~2012-05-24 15:54 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-15 14:10 [U-Boot] [PATCH v4 00/27] updates for Keymile ARM boards Valentin Longchamp
2012-05-15 14:10 ` [U-Boot] [PATCH v4 01/27] arm/km: add board type to boards.cfg Valentin Longchamp
2012-05-15 14:10 ` [U-Boot] [PATCH v4 02/27] arm/km: add piggy mac adress offset for mgcoge3un Valentin Longchamp
2012-05-15 14:10 ` [U-Boot] [PATCH v4 03/27] arm/km: rename CONFIG option CONFIG_KM_DEF_ENV_UPDATE Valentin Longchamp
2012-05-15 14:10 ` [U-Boot] [PATCH v4 04/27] arm/km: use ARRAY_SIZE macro Valentin Longchamp
2012-05-15 14:10 ` [U-Boot] [PATCH v4 05/27] arm/km: fix wrong comment in SDRAM config for mgcoge3un Valentin Longchamp
2012-05-15 14:10 ` [U-Boot] [PATCH v4 06/27] arm/km: change maintainer " Valentin Longchamp
2012-05-17 5:52 ` Heiko Schocher
2012-05-15 14:10 ` [U-Boot] [PATCH v4 07/27] arm/km: remove CONFIG_RESET_PHY_R Valentin Longchamp
2012-05-15 14:10 ` [U-Boot] [PATCH v4 08/27] arm/km: enable mii cmd Valentin Longchamp
2012-05-15 14:10 ` [U-Boot] [PATCH v4 09/27] arm/km: use correct kw_gpio function for NAND/SPI switching Valentin Longchamp
2012-05-15 14:10 ` [U-Boot] [PATCH v4 10/27] arm/kirkwood: protect the ENV_SPI #defines Valentin Longchamp
2012-05-15 14:10 ` [U-Boot] [PATCH v4 11/27] arm/km: add kmnusa board support Valentin Longchamp
2012-05-15 14:10 ` [U-Boot] [PATCH v4 12/27] arm/km: add kmcoge5un " Valentin Longchamp
2012-05-15 14:10 ` [U-Boot] [PATCH v4 13/27] arm/km: convert mgcoge3un target to km_kirkwood Valentin Longchamp
2012-05-15 14:10 ` [U-Boot] [PATCH v4 14/27] arm/km: remove portl2.h and use km_kirkwood instead Valentin Longchamp
2012-05-15 14:10 ` [U-Boot] [PATCH v4 15/27] arm/km: correct init of 88e6352 switch in the reset_phy function Valentin Longchamp
2012-05-15 14:10 ` [U-Boot] [PATCH v4 16/27] arm/km: enable BOCO2 FPGA download support Valentin Longchamp
2012-05-15 14:10 ` [U-Boot] [PATCH v4 17/27] arm/km: cleanup km_kirkwood boards Valentin Longchamp
2012-05-15 14:10 ` [U-Boot] [PATCH v4 18/27] km_arm: redefine piggy 4 reg names to avoid conflicts Valentin Longchamp
2012-05-15 14:10 ` [U-Boot] [PATCH v4 19/27] arm/km: add support for external switch configuration Valentin Longchamp
2012-05-15 14:10 ` [U-Boot] [PATCH v4 20/27] arm/km: enable external switch configuration for kmnusa Valentin Longchamp
2012-05-15 14:10 ` [U-Boot] [PATCH v4 21/27] arm/km: skip FPGA config when already configured Valentin Longchamp
2012-05-15 14:10 ` [U-Boot] [PATCH v4 22/27] arm/km: support the 2 PCIe fpga resets Valentin Longchamp
2012-05-15 14:11 ` [U-Boot] [PATCH v4 23/27] arm/km: add implementation for read_dip_switch Valentin Longchamp
2012-05-15 14:11 ` [U-Boot] [PATCH v4 24/27] arm/km: fix testpin detection for kmcoge5un Valentin Longchamp
2012-05-15 14:11 ` [U-Boot] [PATCH v4 25/27] arm/km: implement weak function board_spi_clam_bus/release Valentin Longchamp
2012-05-24 8:46 ` Prafulla Wadaskar
2012-05-24 15:54 ` Holger Brunck [this message]
2012-05-25 10:36 ` Prafulla Wadaskar
2012-05-15 14:11 ` [U-Boot] [PATCH v4 26/27] km/arm: remove spi toggle command Valentin Longchamp
2012-05-15 14:11 ` [U-Boot] [PATCH v4 27/27] km_arm: use filesize for erase in update command Valentin Longchamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBE59A2.2090401@keymile.com \
--to=holger.brunck@keymile.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox