From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Thu, 24 May 2012 16:13:43 -0600 Subject: [U-Boot] [PATCH 1/3] tegra: usb: Add USB support to Tamonten boards In-Reply-To: <20120524210717.GB13236@avionic-0098.adnet.avionic-design.de> References: <1337843087-8373-1-git-send-email-thierry.reding@avionic-design.de> <4FBE57F0.7070809@wwwdotorg.org> <20120524210717.GB13236@avionic-0098.adnet.avionic-design.de> Message-ID: <4FBEB297.4090008@wwwdotorg.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 05/24/2012 03:07 PM, Thierry Reding wrote: > * Stephen Warren wrote: >> On 05/24/2012 01:04 AM, Thierry Reding wrote: >>> This adds basic USB support for port 0. Device tree support is >>> needed to initialize the USB EHCI and will be added in a >>> subsequent patch. ... >> The code here duplicates changes made to >> board/nvidia/common/board.c. Shouldn't all Tegra boards be using >> that common board code so we don't have to duplicate all this >> early setup for every board vendor using Tegra? Otherwise, every >> time we add I2C, SPI, LP0, ... to board/nvidia/common/board.c, >> you'll just have to make the same change to tamonten.c too. > > I think the problem is U-Boot's build system, which doesn't allow > sharing code between different subdirectories of board/. I have both board/compulab/trimslice and board/compal/paz00 sharing the board/nvidia/common code; take a look at their Makefiles.