From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bo Shen Date: Mon, 28 May 2012 15:31:59 +0800 Subject: [U-Boot] [PATCH v2] video: atmel/lcd: add LCD driver for Atmel new SoC In-Reply-To: <20120525130412.135283e9@wker> References: <1337676449-31346-1-git-send-email-voice.shen@atmel.com> <20120525130412.135283e9@wker> Message-ID: <4FC329EF.8050503@atmel.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Anatolig, On 5/25/2012 19:04, Anatolij Gustschin wrote: > Hi, > > On Tue, 22 May 2012 16:47:29 +0800 > Bo Shen wrote: > ... >> diff --git a/drivers/video/atmel_hlcdfb.c b/drivers/video/atmel_hlcdfb.c >> new file mode 100644 >> index 0000000..0fd7800 >> --- /dev/null >> +++ b/drivers/video/atmel_hlcdfb.c > ... >> +#define lcdc_readl(mmio, reg) __raw_readl((mmio)+(reg)) >> +#define lcdc_writel(mmio, reg, val) __raw_writel((val), (mmio)+(reg)) > > Wolfgang won't accept base + offset for register access, we should use > struct instead. Converted patch is on the way, please review/test. This converted patch has been verified. It works well on Atmel SoC (at91sam9x5ek, and etc). > > Thanks, > Anatolij