public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mmc: tegra: fix boards that used old CONFIG_TEGRA2_MMC build switch
Date: Fri, 01 Jun 2012 11:49:17 -0600	[thread overview]
Message-ID: <4FC9009D.5000506@wwwdotorg.org> (raw)
In-Reply-To: <1338570686-29429-1-git-send-email-twarren@nvidia.com>

On 06/01/2012 11:11 AM, Tom Warren wrote:
> Some boards came in after my tegra2_mmc.* -> tegra_mmc.* change,
> and didn't change CONFIG_TEGRA2_MMC to CONFIG_TEGRA_MMC.
> 
> Signed-off-by: Tom Warren <twarren@nvidia.com>

There is also a fixup for CONFIG_TEGRA2_SPI below as well as for MMC;
perhaps that should be mentioned in the commit description if not subject.

It's not quite accurate to say that the boards came in after the rename;
many of the instances below were things that got applied before the
rename in git history and should really have been part of the rename
patch, even if the patches were possibly posted to the mailing list
after the rename patch was posted, but before being applied.

Grep'ing for the symbols that got renamed in the current
u-boot-tegra/next still shows a lot of hits. For MMC those are all
include guards so it probably doesn't cause bugs. For SPI, there are
some #defines in the driver that didn't get converted.. Should those
fixes be included in this patch too?

  reply	other threads:[~2012-06-01 17:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-01 17:11 [U-Boot] [PATCH] mmc: tegra: fix boards that used old CONFIG_TEGRA2_MMC build switch Tom Warren
2012-06-01 17:49 ` Stephen Warren [this message]
2012-06-01 18:09   ` Tom Warren
2012-06-01 19:00     ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FC9009D.5000506@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox