public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Vágó Tibor" <oreggin@niif.hu>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] fix IDE_BUS(dev) macro
Date: Sun, 03 Jun 2012 17:03:03 +0200	[thread overview]
Message-ID: <4FCB7CA7.4010602@niif.hu> (raw)
In-Reply-To: <20120417190649.GA22913@w500.iskon.local>

Hi,

I've tested this IDE patch on my NAS6220 and it works.

U-boot detect both HDD correctly and boot from them.

Cheers,
Tibor


-------- Original message --------
IDE_BUS assumes that each bus has two devices and thus returns the first
bus even when the second one should be probed.

Signed-off-by: Simon Baatz <gmbnomis@gmail.com>
Tested-by: Luka Perkov <uboot@lukaperkov.net>
---

Simon discovered this while adding support for new board IB NAS6210.

More info can be found here:

http://lists.denx.de/pipermail/u-boot/2012-April/122525.html

When this is commited I will do a coding style cleanup. There are tabs
after few "#define" parts in include/ide.h.

  include/ide.h |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/ide.h b/include/ide.h
index 8ecc9dd..385e909 100644
--- a/include/ide.h
+++ b/include/ide.h
@@ -24,7 +24,7 @@
  #ifndef	_IDE_H
  #define _IDE_H

-#define	IDE_BUS(dev)	(dev >> 1)
+#define IDE_BUS(dev)	(dev / (CONFIG_SYS_IDE_MAXDEVICE / 
CONFIG_SYS_IDE_MAXBUS))

  #define	ATA_CURR_BASE(dev) 
(CONFIG_SYS_ATA_BASE_ADDR+ide_bus_offset[IDE_BUS(dev)])

  parent reply	other threads:[~2012-06-03 15:03 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-17 19:06 [U-Boot] [PATCH] fix IDE_BUS(dev) macro Luka Perkov
2012-04-18 21:37 ` David Purdy
2012-04-19  6:38   ` Albert ARIBAUD
2012-04-21 19:38     ` David Purdy
2012-04-29 20:19     ` Luka Perkov
2012-05-14 19:29       ` Luka Perkov
2012-05-15 19:42         ` Albert ARIBAUD
2012-05-15 20:44           ` Luka Perkov
2012-06-07 13:30           ` Luka Perkov
2012-06-20  8:05             ` Albert ARIBAUD
2012-08-09 20:36               ` Wolfgang Denk
2012-08-13 12:27                 ` Albert ARIBAUD
2012-08-14  8:30                   ` Albert ARIBAUD
2012-08-14 12:33                   ` DrEagle
2012-10-08 18:46         ` [U-Boot] " Tom Rini
2012-06-03 20:23     ` [U-Boot] [PATCH] " Rogan Dawes
2012-06-03 21:25       ` Luka Perkov
2012-04-20  5:17 ` Prafulla Wadaskar
2012-06-03 15:03 ` Vágó Tibor [this message]
2012-06-03 15:03 ` Vágó Tibor
2012-06-03 21:24   ` Luka Perkov
2012-10-07  7:15 ` uboot at lukaperkov.net
2012-10-07  9:28   ` Albert ARIBAUD
2012-10-07 14:40     ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FCB7CA7.4010602@niif.hu \
    --to=oreggin@niif.hu \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox