public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Valentin Longchamp <valentin.longchamp@keymile.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Kirkwood: Add support for Ka-Ro TK71
Date: Mon, 04 Jun 2012 17:36:30 +0200	[thread overview]
Message-ID: <4FCCD5FE.6050707@keymile.com> (raw)
In-Reply-To: <201206011503.43239.marex@denx.de>

Hi Marek and Prafulla,

On 06/01/2012 03:03 PM, Marek Vasut wrote:
> Dear Prafulla Wadaskar,
> 
>>> -----Original Message-----
>>> From: Marek Vasut [mailto:marex at denx.de]
>>> Sent: 31 May 2012 16:37
>>> To: u-boot at lists.denx.de
>>> Cc: Marek Vasut; Prafulla Wadaskar; Wolfgang Denk
>>> Subject: [PATCH] Kirkwood: Add support for Ka-Ro TK71
>>>
>>> Signed-off-by: Marek Vasut <marex@denx.de>
>>> Cc: Prafulla Wadaskar <prafulla@marvell.com>
>>> Cc: Wolfgang Denk <wd@denx.de>
>>> ---
>>>
>>>  board/karo/tk71/Makefile         |   45 ++++++++++
>>>  board/karo/tk71/kwbimage-256.cfg |  174
>>>
>>> ++++++++++++++++++++++++++++++++++++++
>>>
>>>  board/karo/tk71/kwbimage-512.cfg |  174
>>>
>>> ++++++++++++++++++++++++++++++++++++++
>>
>> Dear Marek
>> Just for DRAM size change do not add one more cfg file, configure by
>> default 256MB of RAM in default kwbimg.cfg file and in function
>> board_early_init_f() tune it to 512 for your other board version.
> 
> There's only one single bit flipped between those two kwb configs. Do you think 
> it'd work if we just configured the system for 512MB RAM and ran get_ram_size() 
> to see if it has only 256MB? That'd eliminate two board entries for this tk71.
> 

I would like to have your advice on this as well Prafulla.

We have tested this on km_arm (we will have the same boards with 1/2 the RAM
size) and with the above get_ram_size() it works as expected.

We still should, however, at some point (board_early_init_f() is a good
candidate) then reduce the corresponding RAM CS size (reg @1504 for CS0 so that
the window is the same size as what was detected by get_ram_size). What do you
guys think ?

Valentin

  reply	other threads:[~2012-06-04 15:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-31 11:07 [U-Boot] [PATCH] Kirkwood: Add support for Ka-Ro TK71 Marek Vasut
2012-06-01  7:41 ` Prafulla Wadaskar
2012-06-01 13:03   ` Marek Vasut
2012-06-04 15:36     ` Valentin Longchamp [this message]
2012-06-04 15:46       ` Prafulla Wadaskar
2012-06-04 16:20         ` Holger Brunck
2012-06-04 16:43           ` Prafulla Wadaskar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FCCD5FE.6050707@keymile.com \
    --to=valentin.longchamp@keymile.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox