public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH resend] Added watchdog support for davinchi_dm365evm
Date: Mon, 4 Jun 2012 14:26:41 -0700	[thread overview]
Message-ID: <4FCD2811.8070009@ti.com> (raw)
In-Reply-To: <1338669515-3843-1-git-send-email-stijn.souffriau@essensium.com>

On 06/02/2012 01:38 PM, Stijn Souffriau wrote:
> ---
>  arch/arm/cpu/arm926ejs/davinci/dm365.c         |   61 ++++++++++++++++++++++++
>  arch/arm/include/asm/arch-davinci/timer_defs.h |    2 +
>  board/davinci/dm365evm/dm365evm.c              |   19 ++++++++
>  include/configs/davinci_dm365evm.h             |   11 +++++
>  4 files changed, 93 insertions(+)

First, the proper way to send revised patches is to put 'v2' or 'v3'
rather than resend in the subject and to include, after the full commit
message, "---" and then changes from v1 to v2, v2 to v3 and so forth.
Second, I just re-read this code and the in-tree
arch/arm/cpu/arm926ejs/davinci/timer.c code and think you really really
need to sort out what magic value(s) has changed slightly and re-use
that code.  The reset code is the same.  The programming sequence looks
to be the same.  I just didn't write out all of the non-0 values used to
see what's different.  I'm 99% certain this is small change from one
revision to another of the basic IP block and you need to see what bits
are being set (or not set!) in both cases and see what the differences
between them are all about.

-- 
Tom

      parent reply	other threads:[~2012-06-04 21:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-02 20:38 [U-Boot] [PATCH resend] Added watchdog support for davinchi_dm365evm Stijn Souffriau
2012-06-02 20:38 ` [U-Boot] [PATCH resend] Added UBL_MAGIC_PLL number for ublimage + added automatic page size calculation Stijn Souffriau
2012-06-04 21:29   ` Tom Rini
2012-06-04 21:26 ` Tom Rini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FCD2811.8070009@ti.com \
    --to=trini@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox