From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tom Rini <trini@ti.com>
Date: Mon, 4 Jun 2012 14:29:23 -0700
Subject: [U-Boot] [PATCH resend] Added UBL_MAGIC_PLL number for ublimage
 + added automatic page size calculation
In-Reply-To: <1338669515-3843-2-git-send-email-stijn.souffriau@essensium.com>
References: <1338669515-3843-1-git-send-email-stijn.souffriau@essensium.com>
	<1338669515-3843-2-git-send-email-stijn.souffriau@essensium.com>
Message-ID: <4FCD28B3.4090600@ti.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 06/02/2012 01:38 PM, Stijn Souffriau wrote:
> ---
>  tools/mkimage.h  |    6 ++++++
>  tools/ublimage.c |   29 +++++++++++++++++++++++++++--
>  tools/ublimage.h |    2 ++
>  3 files changed, 35 insertions(+), 2 deletions(-)

In addition to what I just said about v2, v3 and so forth (and needing a
body of the commit message, in this case explain what PLL mode is and so
forth), you have a few cases of '//' or:
/* multi line
 * comments.
 */
that don't match the required style.  Using checkpatch.pl should catch
one or both of these cases.

[snip]
> +	{UBL_MAGIC_SAFE,"safe",	"Safe boot mode",	},
> +	{UBL_MAGIC_PLL,	"pll", "With PLL enabled to have higher ARM/DMA clocks",	},

Missing space.  Thanks!

-- 
Tom