From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 06/10] ARM: add tegra20 support to arm720t
Date: Wed, 06 Jun 2012 13:17:53 -0600 [thread overview]
Message-ID: <4FCFACE1.8030800@wwwdotorg.org> (raw)
In-Reply-To: <20120606182545.GE13311@nvidia.com>
On 06/06/2012 12:25 PM, Allen Martin wrote:
> On Wed, Jun 06, 2012 at 09:39:57AM -0700, Stephen Warren wrote:
>> On 06/05/2012 03:20 PM, Allen Martin wrote:
>>> Add support for tegra20 arm7 boot processor. This processor is used
>>> to power on the Cortex A9 and transfer control to it.
>>
>>> diff --git a/arch/arm/cpu/arm720t/cpu.c b/arch/arm/cpu/arm720t/cpu.c
>>
>>> #elif defined(CONFIG_INTEGRATOR) && defined(CONFIG_ARCH_INTEGRATOR)
>>> /* No cleanup before linux for IntegratorAP/CM720T as yet */
>>> +#elif defined (CONFIG_MACH_TEGRA_GENERIC)
>>> + /* No cleanup before linux for tegra as yet */
>>> #else
>>> #error No cleanup_before_linux() defined for this CPU type
>>> #endif
>>
>> Wouldn't CONFIG_TEGRA2 be a better define to use? Same comment throughout.
>
> The SPL *should* work on tegra30 with only minor changes, so just
> trying to look forward.
Oh, I see. MACH_TEGRA_GENERIC means "some Tegra SoC", and CONFIG_TEGRA*
indicate which one. Coming from my kernel background, MACH_* is a define
for a particular board, and we do have a GENERIC Tegra board, so I got
the wrong end of the stick.
I wonder if it's worth renaming CONFIG_MACH_TEGRA_GENERIC to
CONFIG_TEGRA. There don't appear to be any users of it currently.
next prev parent reply other threads:[~2012-06-06 19:17 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-05 21:20 [U-Boot] [PATCH v2 0/10] split tegra20 arm7 code into separate SPL Allen Martin
2012-06-05 21:20 ` [U-Boot] [PATCH v2 01/10] tegra20: rename tegra2 -> tegra20 Allen Martin
2012-06-06 16:11 ` Stephen Warren
2012-06-06 18:02 ` Allen Martin
2012-06-05 21:20 ` [U-Boot] [PATCH v2 02/10] tegra20: move tegra20 SoC code to arch/arm/cpu/tegra20-common Allen Martin
2012-06-06 16:16 ` Stephen Warren
2012-06-06 18:07 ` Allen Martin
2012-06-05 21:20 ` [U-Boot] [PATCH v2 03/10] mkconfig: add support for SPL CPU Allen Martin
2012-06-06 16:20 ` Stephen Warren
2012-06-06 18:09 ` Allen Martin
2012-06-05 21:20 ` [U-Boot] [PATCH v2 04/10] ARM: Fix arm720t SPL build Allen Martin
2012-06-05 21:20 ` [U-Boot] [PATCH v2 05/10] tegra20: remove timer_init from " Allen Martin
2012-06-05 21:20 ` [U-Boot] [PATCH v2 06/10] ARM: add tegra20 support to arm720t Allen Martin
2012-06-06 16:39 ` Stephen Warren
2012-06-06 18:25 ` Allen Martin
2012-06-06 19:17 ` Stephen Warren [this message]
2012-06-06 22:18 ` Allen Martin
2012-06-06 23:19 ` Stephen Warren
2012-06-05 21:20 ` [U-Boot] [PATCH v2 07/10] tegra20: add SPL config options for seaboard Allen Martin
2012-06-06 16:44 ` Stephen Warren
2012-06-06 18:40 ` Allen Martin
2012-06-07 7:15 ` Sughosh Ganu
2012-06-07 16:36 ` Stephen Warren
2012-06-07 17:04 ` Sughosh Ganu
2012-06-07 20:02 ` Stephen Warren
2012-06-05 21:20 ` [U-Boot] [PATCH v2 08/10] tegra20: add u-boot.t2 target Allen Martin
2012-06-06 16:48 ` Stephen Warren
2012-06-06 19:37 ` Allen Martin
2012-06-06 19:53 ` Tom Warren
2012-06-06 19:57 ` Stephen Warren
2012-06-06 22:00 ` Allen Martin
2012-06-07 2:02 ` Stephen Warren
2012-06-07 17:06 ` Allen Martin
2012-06-05 21:20 ` [U-Boot] [PATCH v2 09/10] tegra20: Remove CPU init code from tegra20 u-boot Allen Martin
2012-06-06 16:51 ` Stephen Warren
2012-06-06 19:42 ` Allen Martin
2012-06-05 21:20 ` [U-Boot] [PATCH v2 10/10] tegra20: Remove armv4t build flags Allen Martin
2012-06-06 16:52 ` Stephen Warren
2012-06-05 21:25 ` [U-Boot] [PATCH v2 0/10] split tegra20 arm7 code into separate SPL Tom Warren
2012-06-05 23:45 ` Allen Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FCFACE1.8030800@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox