From mboxrd@z Thu Jan  1 00:00:00 1970
From: Vikram Narayanan <vikram186@gmail.com>
Date: Mon, 11 Jun 2012 20:30:29 +0530
Subject: [U-Boot] [PATCH 1/3] imx25: Move MXC_GPIO_PORT_TO_NUM to
	imx-regs.h
In-Reply-To: <CAOMZO5CG8xv=CO5n3nGD+K7OMJsntqPcCkWxxJ=+a3gj0bCEvA@mail.gmail.com>
References: <4FD49AA5.7000303@gmail.com> <4FD49AF4.2090506@gmail.com>
	<CAOMZO5CG8xv=CO5n3nGD+K7OMJsntqPcCkWxxJ=+a3gj0bCEvA@mail.gmail.com>
Message-ID: <4FD6080D.1050509@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 6/10/2012 8:03 PM, Fabio Estevam wrote:
> Hi Vikram,
>
> On Sun, Jun 10, 2012 at 10:02 AM, Vikram Narayanan<vikram186@gmail.com>  wrote:
>
>> +
>> +/* Converts a GPIO port number and the internal bit position
>> + * to the GPIO number
>> + */
>> +#define MXC_GPIO_PORT_TO_NUM(port, bit) (((port - 1)<<  5) + (bit&  0x1f))
>
> Just a minor comment:
>
> MXC_GPIO_PORT_TO_NUM looks like a very looong string.
>
> Couldn't we use the same macro as in the Linux kernel (IMX_GPIO_NR) instead?
>
> It is more concise and it would nice to have the same macro name for
> kernel and U-boot.
>
> What do you think?

Yes. That should be a better option. I'll go with it.

~Vikram

> Thanks,
>
> Fabio Estevam