From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Tue, 12 Jun 2012 19:02:16 +0200 Subject: [U-Boot] [PATCH 2/9] NET: fec_mxc.c: Add support for MII for MX5 SOCs In-Reply-To: <4FB24E86.5010509@de.bosch.com> References: <1329906281-15180-1-git-send-email-sbabic@denx.de> <1329906281-15180-2-git-send-email-sbabic@denx.de> <4FB24E86.5010509@de.bosch.com> Message-ID: <4FD77618.8050804@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 15/05/2012 14:39, Dirk Behme wrote: > On 22.02.2012 11:24, Stefano Babic wrote: >> Signed-off-by: Stefano Babic >> CC: Fabio Estevam >> --- Hi Dirk, >> drivers/net/fec_mxc.c | 5 +++++ >> 1 files changed, 5 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c >> index 1fdd071..201e5d2 100644 >> --- a/drivers/net/fec_mxc.c >> +++ b/drivers/net/fec_mxc.c >> @@ -419,8 +419,13 @@ static int fec_open(struct eth_device *edev) >> while (readw(&fec->eth->miigsk_enr) & MIIGSK_ENR_READY) >> udelay(2); >> >> +#if !defined(CONFIG_MII) >> /* configure gasket for RMII, 50 MHz, no loopback, and no echo */ >> writew(MIIGSK_CFGR_IF_MODE_RMII, &fec->eth->miigsk_cfgr); >> +#else >> + /* configure gasket for MII, no loopback, and no echo */ >> + writew(MIIGSK_CFGR_IF_MODE_MII, &fec->eth->miigsk_cfgr); >> +#endif >> >> /* re-enable the gasket */ >> writew(MIIGSK_ENR_EN, &fec->eth->miigsk_enr); > > I have this patch on my list of pending patches. > > What's the status of this? This patch must be reworked. See also the discussion about Timo's patch on http://patchwork.ozlabs.org/patch/153695/ There is some confusion about how to set the interface type. At the beginning, CONFIG_MII or CONFIG_RMII was used, but after the introduction of the MX28, CONFIG_FEC_XCV_TYPE is used. This should be unified, and I tend to use CONFIG_FEC_XCV_TYPE for all i.MX Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================