public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Vikram Narayanan <vikram186@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] tx25: Use generic gpio_* calls
Date: Wed, 13 Jun 2012 22:04:14 +0530	[thread overview]
Message-ID: <4FD8C106.9090200@gmail.com> (raw)
In-Reply-To: <4FD846B5.10402@denx.de>

On 6/13/2012 1:22 PM, Stefano Babic wrote:
> On 12/06/2012 18:37, Vikram Narayanan wrote:
>> Changes from v1:
>> Used appropriate gpio_* lib calls.
>>
>> ---
>> Instead of manipulating gpio registers directly, use the calls
>> from the gpio library.
>
> Changelog must go after the "---" line and commit message before. They
> are swapped. Apart of that..

Sorry for the mix up of commit message and the change log.
Will send a v3 for this.

BTW, did someone test this on tx25?
@John: Any comments from your side?

Thanks,
Vikram

  reply	other threads:[~2012-06-13 16:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-12 16:37 [U-Boot] [PATCH v2] tx25: Use generic gpio_* calls Vikram Narayanan
2012-06-12 16:58 ` Fabio Estevam
2012-06-13  7:52 ` Stefano Babic
2012-06-13 16:34   ` Vikram Narayanan [this message]
2012-06-15 18:26 ` [U-Boot] [PATCH v3] " Vikram Narayanan
2012-06-15 18:35   ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FD8C106.9090200@gmail.com \
    --to=vikram186@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox