From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vikram Narayanan Date: Wed, 13 Jun 2012 23:23:56 +0530 Subject: [U-Boot] mx53loco build fails with CONFIG_VIDEO disabled In-Reply-To: <4FD8CBF1.8060706@denx.de> References: <4FD8C718.9060901@gmail.com> <4FD8CBF1.8060706@denx.de> Message-ID: <4FD8D3B4.70109@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 6/13/2012 10:50 PM, Stefano Babic wrote: > On 13/06/2012 19:00, Vikram Narayanan wrote: >> Hello, >> >> mx53loco build fails when CONFIG_VIDEO and its friends disabled. >> I can send a patch fixing this. >> > > But CONFIG_VIDEO is *not* set in mx53loco.h mainline. Do you mean you > are testing Fabio's patches ? With this (fedab338f3459315cb69627fcf46032ec8df1753) it is already in the master. > Fabio, can you give me an overview about your IPU patches ? I have seen > several patches during my vacation, but it is not clear to me the > status. In patchwork, most of them (but not all) are assigned to > Anatolji. Can you help me to sync myself with the current status ? > >> I _really_ don't like ifdef -ing a lot of stuff. > > Nobody likes it ;-) > >> Instead I'd feel to >> have a separate file in the directory which does this LCD init and FB >> init call, and let the makefile handle the conditional compilation. > > A way we use in the past to have different compilation of the same board > with different features is to use a separate entry into boards.cfg, for > example see imx31_phycore, or also magnesium and imx27lite, or... > > Anyway, when patches for IPU flow into mainline, is there a good reason > to not enable CONFIG_VIDEO for mx53loco ? Though this would be helpful for headless boards, I'm not the right guy. Fabio can give a better picture here. Regards, Vikram > Best regards, > Stefano >