[U-Boot] [PATCH v2 14/19] lcd: Add support for flushing LCD fb from dcache after update

Simon Glass
2012-07-11T05:06:01Z

Hi Stephen,

On Fri, Jun 15, 2012 at 1:51 AM, Stephen Warren <swarren@wwwdotorg.org>wrote:

> On 06/13/2012 10:19 AM, Simon Glass wrote:
> > This provides an option for the LCD to flush the dcache after each update
> > (puts, scroll or clear).
>
> > diff --git a/common/cmd_echo.c b/common/cmd_echo.c
>
> > + /* Use puts() so that the LCD sees it as a new line */
> > if (putnl)
> > - putc('\n');
> > + puts("\n");
>
> That seems fragile - what if someone comes along and uses putc() in some
> other code without having a clue that this requirement exists? What
> stops putc() from detecting \n just like puts()?
>

Yes, actually that change isn't needed, I will remove it.

Regards,
Simon