From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Thu, 14 Jun 2012 15:14:11 -0700 Subject: [U-Boot] [PATCH 1/4] ehci-omap: Do not call dcache_off from omap_ehci_hcd_init In-Reply-To: <201206142357.32995.marex@denx.de> References: <1339700507-26700-1-git-send-email-trini@ti.com> <1339700507-26700-2-git-send-email-trini@ti.com> <201206142357.32995.marex@denx.de> Message-ID: <4FDA6233.3040409@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 06/14/2012 02:57 PM, Marek Vasut wrote: > Dear Tom Rini, > >> This has never been completely sufficient and now happens too late to >> paper over the cache coherency problems with the current USB stack. > > Poor USB maintainer isn't CCed :'-( Whoops, forgot. I don't know why I thought it was you :) > >> >> Signed-off-by: Tom Rini > > But this is always a good thing to see. > > Acked-by: Marek Vasut > >> --- >> drivers/usb/host/ehci-omap.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb/host/ehci-omap.c >> index 1ed7710..292673b 100644 >> --- a/drivers/usb/host/ehci-omap.c >> +++ b/drivers/usb/host/ehci-omap.c >> @@ -246,7 +246,6 @@ int omap_ehci_hcd_init(struct omap_usbhs_board_data >> *usbhs_pdata) if (is_ehci_phy_mode(usbhs_pdata->port_mode[i])) >> omap_ehci_soft_phy_reset(i); >> >> - dcache_disable(); >> hccr = (struct ehci_hccr *)(OMAP_EHCI_BASE); >> hcor = (struct ehci_hcor *)(OMAP_EHCI_BASE + 0x10); > > Best regards, > Marek Vasut