From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Warren <swarren@wwwdotorg.org>
Date: Thu, 14 Jun 2012 17:47:53 -0600
Subject: [U-Boot] [PATCH v2 11/19] tegra: Add LCD support to Nvidia
	boards
In-Reply-To: <1339604395-6621-12-git-send-email-sjg@chromium.org>
References: <1339604395-6621-1-git-send-email-sjg@chromium.org>
	<1339604395-6621-12-git-send-email-sjg@chromium.org>
Message-ID: <4FDA7829.6020106@wwwdotorg.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 06/13/2012 10:19 AM, Simon Glass wrote:
> Add calls to the LCD driver from Nvidia board code.

> diff --git a/board/nvidia/common/board.c b/board/nvidia/common/board.c

> @@ -87,6 +88,9 @@ int board_init(void)

> +#ifdef CONFIG_VIDEO_TEGRA2
> +	tegra_lcd_check_next_stage(gd->blob, 0);
> +#endif

This seems to be conflating video support with LCD support. It would be
quite possible to have a board with no LCD, yet supporting display over
HDMI for example. In other words, shouldn't the ifdef above be something
more like:

#if define(CONFIG_LCD_SUPPORT)
	register_lcd_driver();
#endif
#if defined(CONFIG_VIDEO_TEGRA2)
	tegra_display_init(...);
#endif

and internal to tegra_display_init(), the DT is searched for LCD
controller nodes, and if any are found, they're matched to the LCD
driver registered by the first call above.