public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] imx: Use a clear identification of an unidentified CPU type
Date: Sun, 17 Jun 2012 17:43:36 +0200	[thread overview]
Message-ID: <4FDDFB28.2090303@denx.de> (raw)
In-Reply-To: <1339937889-15538-2-git-send-email-otavio@ossystems.com.br>

On 17/06/2012 14:58, Otavio Salvador wrote:
> In case an unidentified CPU type is detected it now returns
> i.MX<unidentified>, in a const char.
> 
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> Cc: Marek Vasut <marex@denx.de>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Fabio Estevam <fabio.estevam@freescale.com>
> ---

Hi Otavio,


>  arch/arm/cpu/armv7/imx-common/cpu.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/cpu/armv7/imx-common/cpu.c b/arch/arm/cpu/armv7/imx-common/cpu.c
> index b3195dd..77aac7d 100644
> --- a/arch/arm/cpu/armv7/imx-common/cpu.c
> +++ b/arch/arm/cpu/armv7/imx-common/cpu.c
> @@ -66,7 +66,7 @@ char *get_reset_cause(void)
>  
>  #if defined(CONFIG_DISPLAY_CPUINFO)
>  
> -static char *get_imx_type(u32 imxtype)
> +static const char *get_imx_type(u32 imxtype)
>  {
>  	switch (imxtype) {
>  	case 0x63:
> @@ -80,7 +80,7 @@ static char *get_imx_type(u32 imxtype)
>  	case 0x53:
>  		return "53";
>  	default:
> -		return "unknown";
> +		return "<unidentified>";

Taste ist taste... but why <unidentified> is better that unknown ?

Stefano
-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

  parent reply	other threads:[~2012-06-17 15:43 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-17 12:58 [U-Boot] [PATCH 0/3] i.MX refactoring patchset Otavio Salvador
2012-06-17 12:58 ` [U-Boot] [PATCH 1/3] imx: Use a clear identification of an unidentified CPU type Otavio Salvador
2012-06-17 13:05   ` Fabio Estevam
2012-06-17 13:09     ` Otavio Salvador
2012-06-17 13:13       ` Fabio Estevam
2012-06-17 13:21         ` Otavio Salvador
2012-06-17 13:30         ` Marek Vasut
2012-06-17 15:43   ` Stefano Babic [this message]
2012-06-17 15:48     ` Otavio Salvador
2012-06-17 16:03       ` Marek Vasut
2012-06-17 17:50         ` Otavio Salvador
2012-06-17 18:04           ` Stefano Babic
2012-06-17 18:40             ` Marek Vasut
2012-06-17 18:04           ` Marek Vasut
2012-06-17 12:58 ` [U-Boot] [PATCH 2/3] mxs: generalize code for print_cpuinfo() Otavio Salvador
2012-06-17 13:10   ` Fabio Estevam
2012-06-17 13:25   ` Fabio Estevam
2012-06-17 13:35     ` Marek Vasut
2012-06-17 14:14       ` Fabio Estevam
2012-06-17 14:35     ` Otavio Salvador
2012-06-17 15:10       ` Marek Vasut
2012-06-17 15:17         ` Otavio Salvador
2012-06-17 13:28   ` Marek Vasut
2012-06-17 15:49   ` Stefano Babic
2012-06-17 16:02     ` Marek Vasut
2012-06-17 17:56       ` Stefano Babic
2012-06-17 18:03         ` Otavio Salvador
2012-06-17 18:41           ` Marek Vasut
2012-06-17 18:04         ` Marek Vasut
2012-06-17 17:49     ` Otavio Salvador
2012-06-17 12:58 ` [U-Boot] [PATCH 3/3] mx28evk: extend default environment Otavio Salvador
2012-06-17 21:54 ` [U-Boot] [PATCH 0/3] i.MX refactoring patchset Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FDDFB28.2090303@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox