From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Sun, 17 Jun 2012 17:43:36 +0200 Subject: [U-Boot] [PATCH 1/3] imx: Use a clear identification of an unidentified CPU type In-Reply-To: <1339937889-15538-2-git-send-email-otavio@ossystems.com.br> References: <1339937889-15538-1-git-send-email-otavio@ossystems.com.br> <1339937889-15538-2-git-send-email-otavio@ossystems.com.br> Message-ID: <4FDDFB28.2090303@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 17/06/2012 14:58, Otavio Salvador wrote: > In case an unidentified CPU type is detected it now returns > i.MX, in a const char. > > Signed-off-by: Otavio Salvador > Cc: Marek Vasut > Cc: Stefano Babic > Cc: Fabio Estevam > --- Hi Otavio, > arch/arm/cpu/armv7/imx-common/cpu.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/cpu/armv7/imx-common/cpu.c b/arch/arm/cpu/armv7/imx-common/cpu.c > index b3195dd..77aac7d 100644 > --- a/arch/arm/cpu/armv7/imx-common/cpu.c > +++ b/arch/arm/cpu/armv7/imx-common/cpu.c > @@ -66,7 +66,7 @@ char *get_reset_cause(void) > > #if defined(CONFIG_DISPLAY_CPUINFO) > > -static char *get_imx_type(u32 imxtype) > +static const char *get_imx_type(u32 imxtype) > { > switch (imxtype) { > case 0x63: > @@ -80,7 +80,7 @@ static char *get_imx_type(u32 imxtype) > case 0x53: > return "53"; > default: > - return "unknown"; > + return ""; Taste ist taste... but why is better that unknown ? Stefano -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================