From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] i.MX28: Add function to adjust memory parameters
Date: Mon, 18 Jun 2012 17:16:19 +0200 [thread overview]
Message-ID: <4FDF4643.7000100@denx.de> (raw)
In-Reply-To: <201206181623.34836.marex@denx.de>
On 18/06/2012 16:23, Marek Vasut wrote:
> Dear Fabio Estevam,
>
>> Hi Marek,
>>
>> On Thu, May 31, 2012 at 3:45 PM, Marek Vasut <marex@denx.de> wrote:
>>> Call this or similar in your spl_boot.c to adjust the DRAM configuration.
>>> Actually I think even the following value should fix your problem:
>>>
>>> void mx28_adjust_memory_params(uint32_t *dram_vals)
>>> {
>>> dram_vals[0x74 >> 2] = 0x0f02010a;
>>> }
>>
>> I finally had a chance to try this and my mx28evk can boot again with
>> your patch + the code above.
>>
>> How do we handle this? Would you send a v2 with this additional code
>> or should I do it myself after your original patch in this thread gets
>> applied?
>
> Stefano, can you please apply this? So Fabio can apply his on top of it?
I do it.
>
>> Also, please explain to the mortal folks what 'dram_vals[0x74 >> 2] =
>> 0x0f02010a;' means.
>
> Well, check that particular register (memory configuration register at +0x74
> offset) in the datasheet. It's basically adjusting the number of enabled address
> row and columns.
>
>> It is not something very trivial to figure out :-)
>
> It actually is, see above ;-)
I see, but I will never apply a patch programmed in hexadecimal instead
of plain C ;-)
Stefano
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
next prev parent reply other threads:[~2012-06-18 15:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-30 5:43 [U-Boot] [PATCH] i.MX28: Add function to adjust memory parameters Marek Vasut
2012-05-31 18:04 ` Fabio Estevam
2012-05-31 18:45 ` Marek Vasut
2012-06-18 14:17 ` Fabio Estevam
2012-06-18 14:23 ` Marek Vasut
2012-06-18 15:16 ` Stefano Babic [this message]
2012-06-18 15:36 ` Marek Vasut
2012-06-18 15:43 ` Marek Vasut
2012-06-18 16:32 ` Stefano Babic
2012-06-18 17:10 ` Marek Vasut
2012-06-19 7:29 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FDF4643.7000100@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox