[U-Boot] [PATCH] i.MX28: Add function to adjust memory parameters

Marek Vasut
2012-06-18T17:10:25Z

Dear Stefano Babic,

> On 18/06/2012 17:43, Marek Vasut wrote:
> >> So ... what do you expect me to do? The register is called HW_DRAM_CTL29
> >> (very descriptive) ... do you want me to create a file full of
> >> HW_DRAM_CTLnn ?
> >
> > Would adding such comment be enough to satisfy you? (In slightly more
> > polite manner I mean ... damn I'm loosing it, 2 days until exam :'-( ).
> > Sorry for being rough, Stefano.
>
> Do not worry, it is normal before exam ;-)

This ... is not exam. This ... is HELL!!!

> Yes, of course comments will help !

Wait ... it isn't my fault, I didn't publish any code that uses the function
yet, that encodes stuff in hexadecimal. So this patch can be applied as is. It's
Fabio's patch that's at fault here (and I hereby dump all responsibility on
Fabio, keh keh :-) ).

But anyway ... we're gonna have this used a lot and I'm not quite sure how to
handle it. So if comment is enough (aka. I'm hereby adjusting HW_DRAM_CTL29 in
order to set enabled rows and cols differently, refer to "14.8.27 in mx28 TRM"),
let's go with it.

Later, I think we should rework the mem init part. It's there from bootlets and
I think it's all shitty because of that. Well ... the whole SPL is shitty
because it's from bootlets, but that's a longer run, out of scope of this
discussion.

> Best regards,
> Stefano

Best regards,
Marek Vasut